Localised codelists #392
Merged
Localised codelists #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
November 29, 2022 15:09
markbrough
approved these changes
Jan 9, 2023
| return u";".join( | ||
| u"%s" % sec.sector.description if sec.sector and sec.sector.description else u"" | ||
| codelists.localised_description(sec.sector, locale) | ||
| #u"%s" % sec.sector.description if sec.sector and sec.sector.description else u"" |
| return u";".join( | ||
| rrp.region.description if rrp.region and rrp.region.description else "" | ||
| codelists.localised_description(rrp.region, locale) | ||
| #rrp.region.description if rrp.region and rrp.region.description else "" |
| @@ -807,11 +851,13 @@ def wrapper(args): | |||
| (u'transaction_ref', lambda t: t.ref), | |||
| (u'transaction_value_currency', value_currency), | |||
| (u'transaction_value_value-date', lambda t: t.value_date), | |||
| (u'transaction_provider-org', lambda t: t.provider_org_text), | |||
| #(u'transaction_provider-org', lambda t: t.provider_org_text), | |||
Comment on lines
64
to
79
| #class TestVocabularyCodelist(TestCase): | ||
| # def test_vocabulary_codelist(self): | ||
| # self.assertEquals( | ||
| # cl.by_major_version['2'].Vocabulary.humanitarian_global_clusters_interagency_standing_committee.value, | ||
| # "10" | ||
| # ) | ||
| # self.assertEquals( | ||
| # cl.by_major_version['2'].Vocabulary.humanitarian_global_clusters_interagency_standing_committee.description, | ||
| # "Humanitarian Global Clusters (Inter-Agency Standing Committee)" | ||
| # ) | ||
| # | ||
| # def test_vocabulary_codelist_es(self): | ||
| # self.assertEquals( | ||
| # cl.by_major_version['2'].Vocabulary.humanitarian_global_clusters_interagency_standing_committee.translations['es'], | ||
| # "Humanitarian Global Clusters (Inter-Agency Standing Committee)" | ||
| # ) |
There was a problem hiding this comment.
Remove comment? Or what is happening here?
|
Also is #358 now going to be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output codelist descriptions (Sectors and Regions) using the relevant language see: #341