Localised organisation names - part 2 #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 29, 2022 15:23
markbrough
requested changes
Jan 9, 2023
| @@ -807,11 +847,13 @@ def wrapper(args): | |||
| (u'transaction_ref', lambda t: t.ref), | |||
| (u'transaction_value_currency', value_currency), | |||
| (u'transaction_value_value-date', lambda t: t.value_date), | |||
| (u'transaction_provider-org', lambda t: t.provider_org_text), | |||
| #(u'transaction_provider-org', lambda t: t.provider_org_text), | |||
There was a problem hiding this comment.
Should we remove these comments?
| @@ -1099,3 +1099,60 @@ def test_budget_conversion_usd(self): | |||
| def test_budget_conversion_eur(self): | |||
| self.assertEquals(548485.69, self.act.budgets[0].value_eur) # 2011-08-01: GBP 480637 | |||
|
|
|||
| class TestLocalsedOrganisationNames(AppTestCase): | |||
|
This looks good, thank you! A couple of tiny changes - see also #388 changes requested |
added 6 commits
January 10, 2023 15:25
|
Typo fixed in part1 and have updated to remove commented out lines. |
markbrough
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of adding localised organisation names (participating / provider / receiver orgs etc.), as per #341 Adding code to output localised names, after part 1 is merged and updates run