Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n: Add locale key to API and start translating CSV/XLSX headers #356

Merged
merged 1 commit into from
Aug 16, 2022
Merged

i18n: Add locale key to API and start translating CSV/XLSX headers #356

merged 1 commit into from
Aug 16, 2022

Conversation

odscjames
Copy link
Collaborator

@odscjames odscjames commented May 18, 2022 •
edited
Loading

@odscjames odscjames self-assigned this May 18, 2022
@odscjames
Copy link
Collaborator Author

Tests are failing with

RuntimeError: Working outside of request context.

This typically means that you attempted to use functionality that needed
an active HTTP request.  Consult the documentation on testing for
information about how to avoid this problem.

This may need a bit of work to fix - I've had an initial look, but didn't want to spend more time until I was sure the flask-babel approach was the right one to take.

@odscjames
Copy link
Collaborator Author

I think I now know how to fix the tests with work in a different branch, if the rest is good.

@odscjames odscjames force-pushed the 341-spreadsheet-column-headers branch 2 times, most recently from 47a770d to 94950ba Compare July 20, 2022 14:34
@odscjames
i18n: Add locale key to API and start translating CSV/XLSX headers
803ee12 
#341

Alter JS so locale key added to URL's

Ignore locale key when checking for valid filters

Start using flask-babel

Set up our 2 current translations, with no translated strings.

Set up custom extractor to get CSV column headings.

Translate headers in CSV & XLSX

Update README with instructions

Add compile strings stage to deploy

Fix tests
@odscjames odscjames force-pushed the 341-spreadsheet-column-headers branch from 94950ba to 803ee12 Compare July 20, 2022 15:21
@odscjames
Copy link
Collaborator Author

rebased - Tests fixed, custom extractor written, ready for review!

@odscjames odscjames requested review from andylolz and markbrough July 20, 2022 15:30
markbrough
markbrough approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@markbrough markbrough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, thank you! Once it's merged I can provide FR translations for column headers.

@odscjames odscjames merged commit eeb4e30 into main Aug 16, 2022
@odscjames odscjames deleted the 341-spreadsheet-column-headers branch August 16, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markbrough markbrough markbrough approved these changes

@andylolz andylolz Awaiting requested review from andylolz

Assignees

@odscjames odscjames

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odscjames @markbrough