-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localised organisation names - part 1 #388
Conversation
7a88a2b
to
e3b8507
Compare
Hey @radix0000 happy new year! Thanks a lot for this and apologies for not getting round to this before. There's one small issue: in some cases, a publisher will state the default language only on the activity. In that case, we should take that language as being the default of the participating organisation. (If there is no default set, we should assume English.) I was going to try and write a test for this but I think it will be quicker for you to do so rather than waiting for me. So essentially in this case: <iati-activity xml:lang="de">
<reporting-org ref="DE-1" secondary-reporter="0" type="10">
<narrative>Bundesministerium für wirtschaftliche Zusammenarbeit und Entwicklung (BMZ)</narrative>
<narrative xml:lang="en">Federal Ministry for Economic Cooperation and Development (BMZ)</narrative>
</reporting-org>
</iati-activity> The first narrative should be assumed to be German and the second one is English, as declared. Does that make sense? |
Hi @markbrough, hope you have a great new year too! Have updated with code to do what you want I think, and added tests. Do we want to apply the same logic regarding using default language at activity level to titles and descriptions as well? |
Hi @radix0000 this is great, thank you -- and yes please apply the same logic for titles and descriptions. Thank you! |
First part of adding localised organisation names (participating / provider / receiver orgs etc.), as per #341 Add column to Organisation and parsing code, code to output names in part 2, after part 1 merged and uploads run