Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLN] Cleanup frontend after query pushdown #3291

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

Sicheng-Pan
Copy link
Contributor

@Sicheng-Pan Sicheng-Pan commented Dec 12, 2024

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Remove Grpc*Segment implementation in frontend, since they are no longer used after query pushdown
    • Remove test_version_mismatch.py and corresponding exception handling in distributed executor, since we no longer have version mismatch after passing the full collection and segment information form frontend
    • Add a few tests in test_protobuf_translation.py to test translation for collection and segment information
  • New functionality
    • N/A

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?
N/A

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@Sicheng-Pan Sicheng-Pan marked this pull request as ready for review December 12, 2024 01:02
@Sicheng-Pan Sicheng-Pan force-pushed the 12-06-_enh_deprecate_fetchsegmentoperator branch from 931ecb5 to 72314a2 Compare December 12, 2024 20:54
@Sicheng-Pan Sicheng-Pan force-pushed the 12-11-_cln_cleanup_frontend_after_query_pushdown branch from c5cafe8 to bbe4431 Compare December 12, 2024 20:54
@Sicheng-Pan Sicheng-Pan force-pushed the 12-06-_enh_deprecate_fetchsegmentoperator branch from 72314a2 to 41039f0 Compare December 13, 2024 18:32
@Sicheng-Pan Sicheng-Pan force-pushed the 12-11-_cln_cleanup_frontend_after_query_pushdown branch from bbe4431 to 8f997f1 Compare December 13, 2024 18:32
@Sicheng-Pan Sicheng-Pan force-pushed the 12-06-_enh_deprecate_fetchsegmentoperator branch from 41039f0 to d431c5f Compare December 17, 2024 01:51
@Sicheng-Pan Sicheng-Pan force-pushed the 12-11-_cln_cleanup_frontend_after_query_pushdown branch from 8f997f1 to b680440 Compare December 17, 2024 01:51
@Sicheng-Pan Sicheng-Pan mentioned this pull request Dec 17, 2024
1 task
@Sicheng-Pan Sicheng-Pan force-pushed the 12-06-_enh_deprecate_fetchsegmentoperator branch from d431c5f to beca297 Compare December 17, 2024 02:09
@Sicheng-Pan Sicheng-Pan force-pushed the 12-11-_cln_cleanup_frontend_after_query_pushdown branch from b680440 to c6258fd Compare December 17, 2024 02:10
@Sicheng-Pan Sicheng-Pan force-pushed the 12-06-_enh_deprecate_fetchsegmentoperator branch 2 times, most recently from 41b2331 to fd23411 Compare December 17, 2024 02:53
@Sicheng-Pan Sicheng-Pan force-pushed the 12-11-_cln_cleanup_frontend_after_query_pushdown branch from c6258fd to c99c762 Compare December 17, 2024 02:53
@Sicheng-Pan Sicheng-Pan force-pushed the 12-06-_enh_deprecate_fetchsegmentoperator branch from fd23411 to 1589b5c Compare December 17, 2024 21:55
@Sicheng-Pan Sicheng-Pan force-pushed the 12-11-_cln_cleanup_frontend_after_query_pushdown branch from c99c762 to fb478ff Compare December 17, 2024 21:55
Copy link
Contributor Author

Sicheng-Pan commented Dec 17, 2024

Merge activity

  • Dec 17, 5:51 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 17, 5:53 PM EST: Graphite rebased this pull request as part of a merge.
  • Dec 17, 5:54 PM EST: A user merged this pull request with Graphite.

@Sicheng-Pan Sicheng-Pan changed the base branch from 12-06-_enh_deprecate_fetchsegmentoperator to graphite-base/3291 December 17, 2024 22:51
@Sicheng-Pan Sicheng-Pan changed the base branch from graphite-base/3291 to main December 17, 2024 22:51
@Sicheng-Pan Sicheng-Pan force-pushed the 12-11-_cln_cleanup_frontend_after_query_pushdown branch from fb478ff to 069e0e6 Compare December 17, 2024 22:52
@Sicheng-Pan Sicheng-Pan merged commit da0858d into main Dec 17, 2024
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants