-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLN] Cleanup frontend after query pushdown #3291
Merged
Sicheng-Pan
merged 1 commit into
main
from
12-11-_cln_cleanup_frontend_after_query_pushdown
Dec 17, 2024
Merged
[CLN] Cleanup frontend after query pushdown #3291
Sicheng-Pan
merged 1 commit into
main
from
12-11-_cln_cleanup_frontend_after_query_pushdown
Dec 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This was referenced Dec 12, 2024
1 task
codetheweb
approved these changes
Dec 12, 2024
Sicheng-Pan
force-pushed
the
12-06-_enh_deprecate_fetchsegmentoperator
branch
from
December 12, 2024 20:54
931ecb5
to
72314a2
Compare
Sicheng-Pan
force-pushed
the
12-11-_cln_cleanup_frontend_after_query_pushdown
branch
from
December 12, 2024 20:54
c5cafe8
to
bbe4431
Compare
Sicheng-Pan
force-pushed
the
12-06-_enh_deprecate_fetchsegmentoperator
branch
from
December 13, 2024 18:32
72314a2
to
41039f0
Compare
Sicheng-Pan
force-pushed
the
12-11-_cln_cleanup_frontend_after_query_pushdown
branch
from
December 13, 2024 18:32
bbe4431
to
8f997f1
Compare
Sicheng-Pan
force-pushed
the
12-06-_enh_deprecate_fetchsegmentoperator
branch
from
December 17, 2024 01:51
41039f0
to
d431c5f
Compare
Sicheng-Pan
force-pushed
the
12-11-_cln_cleanup_frontend_after_query_pushdown
branch
from
December 17, 2024 01:51
8f997f1
to
b680440
Compare
Sicheng-Pan
force-pushed
the
12-06-_enh_deprecate_fetchsegmentoperator
branch
from
December 17, 2024 02:09
d431c5f
to
beca297
Compare
Sicheng-Pan
force-pushed
the
12-11-_cln_cleanup_frontend_after_query_pushdown
branch
from
December 17, 2024 02:10
b680440
to
c6258fd
Compare
Sicheng-Pan
force-pushed
the
12-06-_enh_deprecate_fetchsegmentoperator
branch
2 times, most recently
from
December 17, 2024 02:53
41b2331
to
fd23411
Compare
Sicheng-Pan
force-pushed
the
12-11-_cln_cleanup_frontend_after_query_pushdown
branch
from
December 17, 2024 02:53
c6258fd
to
c99c762
Compare
Sicheng-Pan
force-pushed
the
12-06-_enh_deprecate_fetchsegmentoperator
branch
from
December 17, 2024 21:55
fd23411
to
1589b5c
Compare
Sicheng-Pan
force-pushed
the
12-11-_cln_cleanup_frontend_after_query_pushdown
branch
from
December 17, 2024 21:55
c99c762
to
fb478ff
Compare
Sicheng-Pan
changed the base branch from
12-06-_enh_deprecate_fetchsegmentoperator
to
graphite-base/3291
December 17, 2024 22:51
Sicheng-Pan
force-pushed
the
12-11-_cln_cleanup_frontend_after_query_pushdown
branch
from
December 17, 2024 22:52
fb478ff
to
069e0e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
Grpc*Segment
implementation in frontend, since they are no longer used after query pushdowntest_version_mismatch.py
and corresponding exception handling in distributed executor, since we no longer have version mismatch after passing the full collection and segment information form frontendtest_protobuf_translation.py
to test translation for collection and segment informationTest plan
How are these changes tested?
pytest
for python,yarn test
for js,cargo test
for rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?
N/A