Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Propagate segment information from frontend to query node #3255

Merged
merged 4 commits into from
Dec 17, 2024
Merged

[ENH] Propagate segment information from frontend to query node #3255

merged 4 commits into from
Dec 17, 2024

Conversation

Sicheng-Pan
Copy link
Contributor

@Sicheng-Pan Sicheng-Pan commented Dec 6, 2024 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • N/A
  • New functionality
    • Propagate full segment information from frontend to query node

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?
N/A

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@Sicheng-Pan Sicheng-Pan mentioned this pull request Dec 6, 2024
Merged
1 task
@Sicheng-Pan Graphite App
Copy link
Contributor Author

Sicheng-Pan commented Dec 6, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sicheng-Pan Sicheng-Pan mentioned this pull request Dec 6, 2024
Merged
1 task
@Sicheng-Pan Sicheng-Pan marked this pull request as ready for review December 6, 2024 01:06
@Sicheng-Pan Sicheng-Pan force-pushed the 12-05-_enh_propagate_segment_information_from_frontend_to_query_node branch 2 times, most recently from d95943c to cb282ca Compare December 6, 2024 01:10
@Sicheng-Pan Sicheng-Pan force-pushed the 12-05-_enh_use_getcollectionwithsegments_endpoint_in_frontend branch from 40bad39 to 4575446 Compare December 6, 2024 17:07
@Sicheng-Pan Sicheng-Pan force-pushed the 12-05-_enh_propagate_segment_information_from_frontend_to_query_node branch from cb282ca to 3be574d Compare December 6, 2024 17:07
@Sicheng-Pan Sicheng-Pan mentioned this pull request Dec 6, 2024
Merged
1 task
@Sicheng-Pan Sicheng-Pan force-pushed the 12-05-_enh_use_getcollectionwithsegments_endpoint_in_frontend branch from 4575446 to 513c387 Compare December 6, 2024 21:44
@Sicheng-Pan Sicheng-Pan force-pushed the 12-05-_enh_propagate_segment_information_from_frontend_to_query_node branch from 3be574d to e02d7a5 Compare December 6, 2024 21:44
@Sicheng-Pan Sicheng-Pan force-pushed the 12-05-_enh_use_getcollectionwithsegments_endpoint_in_frontend branch from 513c387 to 2b7a94b Compare December 9, 2024 18:56
@Sicheng-Pan Sicheng-Pan force-pushed the 12-05-_enh_propagate_segment_information_from_frontend_to_query_node branch 2 times, most recently from 7069b15 to fdc1b25 Compare December 9, 2024 23:26
@Sicheng-Pan Sicheng-Pan force-pushed the 12-05-_enh_use_getcollectionwithsegments_endpoint_in_frontend branch from 23d9d3e to 5519de7 Compare December 9, 2024 23:57
@Sicheng-Pan Sicheng-Pan force-pushed the 12-05-_enh_propagate_segment_information_from_frontend_to_query_node branch from fdc1b25 to 56c2d2d Compare December 9, 2024 23:57
@Sicheng-Pan Sicheng-Pan force-pushed the 12-05-_enh_use_getcollectionwithsegments_endpoint_in_frontend branch from 5519de7 to db74461 Compare December 10, 2024 00:46
@Sicheng-Pan Sicheng-Pan force-pushed the 12-05-_enh_propagate_segment_information_from_frontend_to_query_node branch 4 times, most recently from 7ce2047 to 1022564 Compare December 11, 2024 19:11
@Sicheng-Pan Sicheng-Pan force-pushed the 12-05-_enh_use_getcollectionwithsegments_endpoint_in_frontend branch from 90b3cb9 to bf4901b Compare December 11, 2024 19:31
@Sicheng-Pan Sicheng-Pan force-pushed the 12-05-_enh_propagate_segment_information_from_frontend_to_query_node branch from 1022564 to 81e1a4e Compare December 11, 2024 19:31
@Sicheng-Pan Sicheng-Pan force-pushed the 12-05-_enh_use_getcollectionwithsegments_endpoint_in_frontend branch from bf4901b to c43586d Compare December 11, 2024 20:31
@Sicheng-Pan Sicheng-Pan force-pushed the 12-05-_enh_propagate_segment_information_from_frontend_to_query_node branch 2 times, most recently from 94cb043 to 4003aa8 Compare December 11, 2024 20:44
@Sicheng-Pan Sicheng-Pan mentioned this pull request Dec 12, 2024
Merged
1 task
sanketkedia
sanketkedia reviewed Dec 16, 2024
View reviewed changes
idl/chromadb/proto/query_executor.proto
@@ -6,9 +6,15 @@ import "chromadb/proto/chroma.proto";

message ScanOperator {
Collection collection = 1;
// Deprecated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add a bit more information as to why it has been deprecated and what is the new course of action?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be removed in the next PR

sanketkedia
sanketkedia reviewed Dec 16, 2024
View reviewed changes
rust/worker/src/server.rs

let record_uuid = SegmentUuid::from_str(&scan.record_id)
.map_err(|_| Status::invalid_argument("Invalid UUID for Record segment"))?;
let metadata_uuid =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment here on the unwrap_or behavior

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a temporary impl that will be removed in the next PR

@Sicheng-Pan Sicheng-Pan mentioned this pull request Dec 17, 2024
Merged
1 task
@Sicheng-Pan Sicheng-Pan force-pushed the 12-05-_enh_use_getcollectionwithsegments_endpoint_in_frontend branch from 9a70ee3 to fcda18a Compare December 17, 2024 02:09
@Sicheng-Pan Sicheng-Pan force-pushed the 12-05-_enh_propagate_segment_information_from_frontend_to_query_node branch from 69436a2 to b3b4a88 Compare December 17, 2024 02:09
@Sicheng-Pan Graphite App
Copy link
Contributor Author

Sicheng-Pan commented Dec 17, 2024 •
edited
Loading

Merge activity

  • Dec 16, 9:44 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 16, 9:51 PM EST: Graphite rebased this pull request as part of a merge.
  • Dec 16, 9:52 PM EST: A user merged this pull request with Graphite.

@Sicheng-Pan Sicheng-Pan changed the base branch from 12-05-_enh_use_getcollectionwithsegments_endpoint_in_frontend to graphite-base/3255 December 17, 2024 02:46
@Sicheng-Pan Sicheng-Pan changed the base branch from graphite-base/3255 to main December 17, 2024 02:48
@Sicheng-Pan Sicheng-Pan force-pushed the 12-05-_enh_propagate_segment_information_from_frontend_to_query_node branch from b3b4a88 to a3cf8dd Compare December 17, 2024 02:50
@Sicheng-Pan Sicheng-Pan merged commit 0907a89 into main Dec 17, 2024
75 of 76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanketkedia sanketkedia sanketkedia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sicheng-Pan @sanketkedia