Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TST] Benchmark query node #3320

Merged
merged 5 commits into from
Dec 17, 2024
Merged

[TST] Benchmark query node #3320

merged 5 commits into from
Dec 17, 2024

Conversation

Sicheng-Pan
Copy link
Contributor

@Sicheng-Pan Sicheng-Pan commented Dec 17, 2024 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • N/A
  • New functionality
    • Implement benchmark that runs the entire get/knn orchestrator

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

This was referenced Dec 17, 2024
Merged
Merged
Merged
Merged
Merged
@Sicheng-Pan Graphite App
Copy link
Contributor Author

Sicheng-Pan commented Dec 17, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@Sicheng-Pan Sicheng-Pan marked this pull request as ready for review December 17, 2024 01:52
@Sicheng-Pan Sicheng-Pan force-pushed the 12-11-_cln_cleanup_frontend_after_query_pushdown branch from b680440 to c6258fd Compare December 17, 2024 02:10
@Sicheng-Pan Sicheng-Pan force-pushed the 12-13-_tst_benchmark_query_node branch from 64d0835 to 9e61ffc Compare December 17, 2024 02:10
@Sicheng-Pan Sicheng-Pan force-pushed the 12-11-_cln_cleanup_frontend_after_query_pushdown branch from c6258fd to c99c762 Compare December 17, 2024 02:53
@Sicheng-Pan Sicheng-Pan force-pushed the 12-13-_tst_benchmark_query_node branch from 9e61ffc to 4d12af8 Compare December 17, 2024 02:54
@Sicheng-Pan Sicheng-Pan force-pushed the 12-11-_cln_cleanup_frontend_after_query_pushdown branch from c99c762 to fb478ff Compare December 17, 2024 21:55
@Sicheng-Pan Sicheng-Pan force-pushed the 12-13-_tst_benchmark_query_node branch from 4d12af8 to 9df14a7 Compare December 17, 2024 21:55
@Sicheng-Pan Graphite App
Copy link
Contributor Author

Sicheng-Pan commented Dec 17, 2024 •
edited
Loading

Merge activity

  • Dec 17, 5:51 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 17, 5:57 PM EST: Graphite rebased this pull request as part of a merge.
  • Dec 17, 5:58 PM EST: A user merged this pull request with Graphite.

@Sicheng-Pan Sicheng-Pan changed the base branch from 12-11-_cln_cleanup_frontend_after_query_pushdown to graphite-base/3320 December 17, 2024 22:52
@Sicheng-Pan Sicheng-Pan changed the base branch from graphite-base/3320 to main December 17, 2024 22:54
@Sicheng-Pan Sicheng-Pan force-pushed the 12-13-_tst_benchmark_query_node branch from 9df14a7 to a5996c5 Compare December 17, 2024 22:56
@Sicheng-Pan Sicheng-Pan merged commit d833e53 into main Dec 17, 2024
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Sicheng-Pan