Deprecated unused proto fields

chroma-core · Dec 12, 2024 · 72314a2 · 72314a2
1 parent 91bb7a6
commit 72314a2
Show file tree

Hide file tree

Showing 4 changed files with 36 additions and 52 deletions.
diff --git a/chromadb/proto/query_executor_pb2.py b/chromadb/proto/query_executor_pb2.py
diff --git a/chromadb/proto/query_executor_pb2.pyi b/chromadb/proto/query_executor_pb2.pyi
diff --git a/idl/chromadb/proto/query_executor.proto b/idl/chromadb/proto/query_executor.proto
@@ -6,12 +6,8 @@ import "chromadb/proto/chroma.proto";
 
 message ScanOperator {
     Collection collection = 1;
-    // Deprecated
-    string knn_id = 2;
-    // Deprecated
-    string metadata_id = 3;
-    // Deprecated
-    string record_id = 4;
+    // Reserve for deprecated fields
+    reserved 2, 3, 4;
     Segment knn = 5;
     Segment metadata = 6;
     Segment record = 7;

diff --git a/rust/worker/src/server.rs b/rust/worker/src/server.rs
@@ -462,12 +462,6 @@ mod tests {
                 log_position: 0,
                 version: 0,
             }),
-            // Deprecated
-            knn_id: "".to_string(),
-            // Deprecated
-            metadata_id: "".to_string(),
-            // Deprecated
-            record_id: "".to_string(),
             knn: Some(chroma_proto::Segment {
                 id: Uuid::new_v4().to_string(),
                 r#type: "urn:chroma:segment/vector/hnsw-distributed".to_string(),