Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop bionic support #27

Merged
merged 3 commits into from
Jan 9, 2024
Merged

drop bionic support #27

merged 3 commits into from
Jan 9, 2024

Conversation

rgildein
Copy link

@rgildein rgildein commented Jan 8, 2024

The functional tests are failing for Bionic series, and since we do not need to support it anymore.

@rgildein rgildein requested a review from a team January 8, 2024 16:08
@rgildein rgildein self-assigned this Jan 8, 2024
agileshaw
agileshaw suggested changes Jan 8, 2024
View reviewed changes
Copy link

@agileshaw agileshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we no longer support bionic, we should un-pin ops in requirements.txt and update README (which contains an example of bionic deployment).

@rgildein rgildein mentioned this pull request Jan 8, 2024
Closed
@dashmage dashmage mentioned this pull request Jan 9, 2024
Merged
@Pjack Pjack mentioned this pull request Jan 9, 2024
Merged
@rgildein
Copy link
Author

rgildein commented Jan 9, 2024

Now that we no longer support bionic, we should un-pin ops in requirements.txt and update README (which contains an example of bionic deployment).

Thanks, I removed any mention of Bionic (from examples, tests and default values).

@rgildein rgildein requested a review from agileshaw January 9, 2024 14:54
This was referenced Jan 9, 2024
Merged
Closed
agileshaw
agileshaw reviewed Jan 9, 2024
View reviewed changes
Copy link

@agileshaw agileshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small change suggested inline, otherwise looks good.

tests/functional/test_charm.py Outdated Show resolved Hide resolved
@rgildein rgildein requested a review from agileshaw January 9, 2024 17:57
agileshaw
agileshaw approved these changes Jan 9, 2024
View reviewed changes
Copy link

@agileshaw agileshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@rgildein rgildein merged commit ba80a6e into canonical:main Jan 9, 2024
4 checks passed
@rgildein rgildein deleted the ci/drop-bionic branch January 9, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudeephb sudeephb sudeephb approved these changes

@agileshaw agileshaw agileshaw approved these changes

@aieri aieri aieri approved these changes

@Pjack Pjack Awaiting requested review from Pjack Pjack is a code owner automatically assigned from canonical/soleng-reviewers

@jneo8 jneo8 Awaiting requested review from jneo8 jneo8 is a code owner automatically assigned from canonical/soleng-reviewers

Assignees

@rgildein rgildein

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rgildein @aieri @agileshaw @sudeephb