Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CODEOWNERS #26

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Create CODEOWNERS #26

merged 1 commit into from
Jan 11, 2024

Conversation

dashmage
Copy link

@dashmage dashmage commented Jan 8, 2024

No description provided.

Copy link

@Pjack Pjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some codes has overlap with this #27. We can merge this after that.

@Pjack Pjack requested review from jneo8 and sudeephb January 10, 2024 06:28
Copy link

@sudeephb sudeephb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dashmage
Copy link
Author

Removed the bionic changes from this PR and rebased from main branch.

@sudeephb sudeephb self-requested a review January 10, 2024 08:29
Copy link

@sudeephb sudeephb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dashmage dashmage merged commit d94ee53 into canonical:main Jan 11, 2024
4 checks passed
@dashmage dashmage deleted the add-codeowners branch January 11, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants