Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refined functions to get packages indices #28

Merged
merged 5 commits into from
Jan 12, 2024

Conversation

rgildein
Copy link

@rgildein rgildein commented Jan 8, 2024

Add the _get_package_indices, which is searching all "**/Packages*" in dists, but instead of picking up only the first path, it's filtering a path from the same parent directory.

Add the _get_package_indices, which is searching all "**/Packages*"
in dists, but instead of picking up only the first path, it's filtering
a path from the same parent directory.
@rgildein rgildein requested review from Vultaire and a team January 8, 2024 16:52
@rgildein rgildein self-assigned this Jan 8, 2024
@rgildein
Copy link
Author

rgildein commented Jan 9, 2024

blocked by: #27

@rgildein rgildein mentioned this pull request Jan 9, 2024
Copy link

@jneo8 jneo8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@chanchiwai-ray chanchiwai-ray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the improvement to get package indices; and also thanks for enhance the code quality a bit.

Copy link

@agileshaw agileshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@dashmage dashmage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small comment. Really nice PR and LGTM!

tests/unit/test_utils.py Outdated Show resolved Hide resolved
@rgildein rgildein requested review from dashmage and jneo8 January 12, 2024 08:45
Copy link

@jneo8 jneo8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rgildein rgildein merged commit 4f7dbca into canonical:main Jan 12, 2024
4 checks passed
@rgildein rgildein deleted the bug/2046088 branch January 12, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants