Mark/1178 supports loading swapped-axes image cubes #1194

markccchiang · 2022-09-08T02:39:57Z

Description

What is implemented or fixed? Mention the linked issue(s), if any.
Support loading swapped axes image cubes Support loading swapped-axes image cubes (eg RA-Channel-Dec) (backend) #1178.
How does this PR solve the issue? Give a brief summary.
Fix the render axes to [0, 1], i.e., the first two axes from the header. The original render axes setting is direction axes, if any.
Are there any companion PRs (frontend, protobuf)?
~~No need to change the protobuf. But it seems the AST plot settings have to be modified in the frontend, in order to plot RA-channel or DEC-channel coordinates.~~
Companion PRs: protobuf PR 77 and frontend PR 2011.
Is there anything else that testers should know (e.g. exactly how to reproduce the issue)?
This is the new feature. We may need sample image cubes with swapped axes for testing.

Checklist

changelog updated ~~/ no changelog update needed~~
~~e2e test passing~~ / added corresponding fix
protobuf updated to the latest dev commit ~~/ no protobuf update needed~~
added reviewers and assignee
added ZenHub estimate, milestone, and release

…mark/1178_set_render_axes_as_0_and_1

kswang1029 · 2022-11-30T01:49:10Z

@markccchiang the file info for a PV image needs a fix. The offset axis is with the "NA" label. It should be "Spatial" I guess?

In fact maybe we can simply display CTYPE1/2/3/4, so

Shape = [256, 256, 480, 1] (X, Y, Spectral, Stokes)

becomes

Shape = [256, 256, 480, 1] (RA, DEC, FREQ, STOKES)

or

Shape = [256, 256, 480, 1] (X: RA, Y: DEC, Z: FREQ, W: STOKES)

for example.

kswang1029 · 2022-11-30T01:59:54Z

@markccchiang another file info issue: for a rotated cube, there is a repeated (and incorrect) "frequency range" info.

pford · 2023-02-08T14:09:08Z

Oops, this was my fault. For some reason casacore uses Freq for spectral worldAxisNames instead of the actual header value. Sorry @markccchiang you will have to change it back to iterating through header entries.

kswang1029 · 2023-02-20T03:37:17Z

to handle the general cases like
(0:ra, 1:dec, 2:stokes, 3:channel) ==> 24 combinations
(0:ra, 1:dec, 2:channel, 3:stokes) ==> 24 combinations
(0:ra, 1:dec, 2:channel) ==> 6 combinations
(0:ra, 1:dec, 2:stokes) ==> 6 combinations

we need to incorporate a general rule in the current PR to ignore stokes (if it exists) first, then from the rest, we pick up the 1st as x-axis and the 2nd as y-axis. The rest (if it exists) is z-axis (iterable via the animator). stokes (if it exists) remains as the polarization axis.

kswang1029 · 2023-02-24T04:52:56Z

FYI. Working on fixing and add basic e2e tests for this new feature now. Once done I will approve this PR.

kswang1029 · 2023-02-24T09:14:45Z

@markccchiang one minor issue spotted in the file info.

Name = gaussian_array_large_GALACTIC_2031.image
Data type = floatShape = [4, 746, 10, 746] (STOKES, GLON, FREQ, GLAT)
Number of channels = 10
Number of polarizations = 4
Coordinate type = Longitude, Frequency
Projection = SIN
Image reference pixels = [374, 6]
Image reference coords = [-132.27.25.3488, 1.4204e+09 Hz]
Image ref coords (deg) = [-132.457 deg, 1.4204e+09 Hz]

longitude is [0 deg, 360 deg].

… profiles

kswang1029

feature-wise this is looking good for the current scope - supporting image visualization of a swapped-axes cube. 👍 Please proceed code review.

…mark/1178_set_render_axes_as_0_and_1

confluence

I think that this is OK; I would just like to rename these variables. We have previously referred to the X and Y axes in the code as "spatial" rather than "direction" axes, and I think it will be less confusing if we stick to that naming convention.

confluence · 2023-03-13T09:15:20Z

src/ImageData/FileLoader.cc

@@ -175,9 +175,11 @@ std::shared_ptr<casacore::CoordinateSystem> FileLoader::GetCoordinateSystem(cons
    return std::make_shared<casacore::CoordinateSystem>();
 }

-bool FileLoader::FindCoordinateAxes(casacore::IPosition& shape, int& spectral_axis, int& z_axis, int& stokes_axis, std::string& message) {
+bool FileLoader::FindCoordinateAxes(casacore::IPosition& shape, std::vector<int>& direction_axes, int& spectral_axis, int& stokes_axis,


I would use "spatial" instead of "direction" in all these variables and comments, for consistency with our existing terminology.

just a IIRC note, in casacore it is called directional axis. This may be why. 🙂

If only we could all decide on one standard! 😄

kswang1029

looking good. new e2e tests are implemented.

…TAvis/carta-backend into mark/1178_set_render_axes_as_0_and_1

github-actions · 2023-03-22T10:52:08Z

Package	Line Rate	Health
src.Cache	68%	➖
src.DataStream	52%	➖
src.FileList	68%	➖
src.Frame	51%	➖
src.HttpServer	43%	➖
src.ImageData	28%	❌
src.ImageFitter	92%	✔
src.ImageGenerators	52%	➖
src.ImageStats	74%	➖
src.Logger	44%	➖
src.Main	54%	➖
src.Region	22%	❌
src.Session	30%	❌
src.Table	52%	➖
src.ThreadingManager	87%	✔
src.Timer	85%	✔
src.Util	50%	➖
Summary	40% (6787 / 16902)	➖

markccchiang added 4 commits September 8, 2022 09:53

Do not fix the render axes to direction axes

aa340bc

Modify the changelog

bcebbc3

Add axes numbers for Ra, Dec, Spectral and Stokes in the file info

fcf9c33

Add axes numbers in the file info extended message

70a10bf

markccchiang changed the title ~~Mark/1178 set render axes as 0 and 1~~ Mark/1178 supports loading swapped-axes image cubes Sep 11, 2022

markccchiang added 5 commits September 13, 2022 00:38

A minor code change

a6c5dc1

Fix the problem of showing PV image coordinates for swapped axes cubes

d212cbb

Identify key words GLON or GLAT as direction axes

c6d382d

Remove unused codes

97798ef

Modify the protobuf message AxesNumbers

fa79f05

markccchiang mentioned this pull request Sep 13, 2022

Mark/support loading swapped axes images CARTAvis/carta-frontend#2011

Merged

3 tasks

markccchiang added 12 commits October 3, 2022 10:39

Change axis indices from 0-based to 1-based in the axes_numbers message

c431952

Minor code changes and refactoring

c14c257

Fix an unit test error for the file info

09f229e

Revert coordinate settings in PV generator

88d2037

Solve a merge conflict in changelog

da2949c

Refactor codes

91d4ef9

Merge branch 'dev' of https://github.com/CARTAvis/carta-backend into …

0a4f763

…mark/1178_set_render_axes_as_0_and_1

Update the protobuf submodule

1f72ab2

Solve merge conflicts

f0fac19

Solve a merge conflict in changelog

6c36e34

Merge branch 'dev' of https://github.com/CARTAvis/carta-backend into …

671024d

…mark/1178_set_render_axes_as_0_and_1

Minor code changes

8e65f58

markccchiang marked this pull request as ready for review November 29, 2022 05:44

markccchiang requested review from confluence, pford and kswang1029 November 29, 2022 05:45

markccchiang mentioned this pull request Nov 29, 2022

Mark/add axes numbers CARTAvis/carta-protobuf#77

Merged

Solve a merge conflict in the changlog

732b788

acdo2002 mentioned this pull request Feb 4, 2023

Improve the ICD test for swap image backend PR CARTAvis/ICD-RxJS#2

Closed

markccchiang added 3 commits February 22, 2023 09:46

Skip the stokes axis when rendering an image

55d6f75

Get axis names from header entries that shown on the file info panel

77a33ff

Modify the file info tester

91e1c58

markccchiang added 3 commits February 26, 2023 21:14

Represent the longitudinal coordinate value in the rangge [0, 360] deg

793a2b6

Correct the syntax to initialize values for axis names

a9463a4

Fix the reversed PV generation when getting with fixed angular region…

36868ea

… profiles

acdo2002 mentioned this pull request Mar 7, 2023

Update the tested for the swapped images header CARTAvis/ICD-RxJS#4

Closed

kswang1029 approved these changes Mar 7, 2023

View reviewed changes

Merge branch 'dev' of https://github.com/CARTAvis/carta-backend into …

3fe5529

…mark/1178_set_render_axes_as_0_and_1

confluence requested changes Mar 13, 2023

View reviewed changes

markccchiang added 2 commits March 13, 2023 23:37

Rename variables for directional axes as spatial axes

3a3085a

Update the protobuf messages for spatial axes

b1e7177

kswang1029 self-requested a review March 14, 2023 06:40

markccchiang added 2 commits March 15, 2023 01:06

Fix the reference Dec value shown on the file info panel

a01fe00

Minor code changes

341e799

kswang1029 approved these changes Mar 15, 2023

View reviewed changes

confluence approved these changes Mar 15, 2023

View reviewed changes

confluence added 2 commits March 22, 2023 12:44

bumped protobuf commit

c446d83

Merge branch 'mark/1178_set_render_axes_as_0_and_1' of github.com:CAR…

62b2c48

…TAvis/carta-backend into mark/1178_set_render_axes_as_0_and_1

confluence merged commit 08832e1 into dev Mar 22, 2023

confluence deleted the mark/1178_set_render_axes_as_0_and_1 branch March 22, 2023 11:01

kswang1029 mentioned this pull request Mar 29, 2023

Support loading swapped-axes image cubes (eg RA-Channel-Dec) (backend) #1178

Open

kswang1029 mentioned this pull request May 9, 2023

support spatial-spectral (aka PV) images where the spatial axis is RA/Dec/GLON/GLAT etc. (backend) #1173

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mark/1178 supports loading swapped-axes image cubes #1194

Mark/1178 supports loading swapped-axes image cubes #1194

markccchiang commented Sep 8, 2022 •

edited by kswang1029

Loading

kswang1029 commented Nov 30, 2022 •

edited

Loading

kswang1029 commented Nov 30, 2022

pford commented Feb 8, 2023

kswang1029 commented Feb 20, 2023 •

edited

Loading

kswang1029 commented Feb 24, 2023

kswang1029 commented Feb 24, 2023 •

edited

Loading

kswang1029 left a comment

confluence left a comment

confluence Mar 13, 2023

kswang1029 Mar 13, 2023

confluence Mar 13, 2023

kswang1029 left a comment

github-actions bot commented Mar 22, 2023

Mark/1178 supports loading swapped-axes image cubes #1194

Mark/1178 supports loading swapped-axes image cubes #1194

Conversation

markccchiang commented Sep 8, 2022 • edited by kswang1029 Loading

kswang1029 commented Nov 30, 2022 • edited Loading

kswang1029 commented Nov 30, 2022

pford commented Feb 8, 2023

kswang1029 commented Feb 20, 2023 • edited Loading

kswang1029 commented Feb 24, 2023

kswang1029 commented Feb 24, 2023 • edited Loading

kswang1029 left a comment

Choose a reason for hiding this comment

confluence left a comment

Choose a reason for hiding this comment

confluence Mar 13, 2023

Choose a reason for hiding this comment

kswang1029 Mar 13, 2023

Choose a reason for hiding this comment

confluence Mar 13, 2023

Choose a reason for hiding this comment

kswang1029 left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 22, 2023

markccchiang commented Sep 8, 2022 •

edited by kswang1029

Loading

kswang1029 commented Nov 30, 2022 •

edited

Loading

kswang1029 commented Feb 20, 2023 •

edited

Loading

kswang1029 commented Feb 24, 2023 •

edited

Loading