-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark/support loading swapped axes images #2011
Conversation
… mark/support_loading_swapped_axes_images
… mark/support_loading_swapped_axes_images
… mark/support_loading_swapped_axes_images
Again, for the current purpose, we don’t focus on any region related analyses. It is not the scope here, whether the results are correct or not. This is a doc capturing all affected analyses https://docs.google.com/document/d/1eNLZt-VxSrzeYaOFjajJqbKXzIOo-u29xL7g3Cstz2c/edit |
@markccchiang when a swapped cube is loaded, we will still need to display |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feature-wise this is looking good for the current scope - supporting image visualization of a swapped-axes cube. 👍 Please proceed code review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are looking good! I only have two minor comments.
for some reason e49334d introduces test failures for regions. world coordinates of the region are not updating. There are errors from AST. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good. new e2e tests are implemented.
… mark/support_loading_swapped_axes_images
Description
This is intended to solve #1953, plotting coordinates for swapped-axes image cubes. It has to work with the backend PR 1194. To test it we may need more sample images with swapped-axes cubes.
Checklist
e2e test passing/ added corresponding fix/ no protobuf update needed