Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support loading swapped-axes image cubes (eg RA-Channel-Dec) (backend) #1178

Open
kswang1029 opened this issue Aug 4, 2022 · 6 comments
Open
Assignees
Labels
enhancement New feature or request requiring frontend this backend issue requires work in both frontend and backend

Comments

@kswang1029
Copy link
Contributor

kswang1029 commented Aug 4, 2022

user feedback from v3 beta test

This is to support rotated cubes such as RA-Channel-Dec.

The backend needs to be able to recognize such cubes and generate proper file info.

The companion frontend issue is CARTAvis/carta-frontend#1953

@kswang1029 kswang1029 added the enhancement New feature or request label Aug 4, 2022
@kswang1029 kswang1029 added the requiring frontend this backend issue requires work in both frontend and backend label Aug 4, 2022
@markccchiang
Copy link
Contributor

@kswang1029 Do we have the sample file of the rotating cube to do the test?

@markccchiang
Copy link
Contributor

@kswang1029 Is it OK to load a swapped-axes cube and render it as ra-dec image for now? The backend needs to tell the frontend real axis numbers of ra, dec, spectral, and stokes axes. So the frontend can render a ra-dec image with the correct coordinate system (in AST setting). I have created a backend branch mark/1178_support_swapped_axes_images and a frontend branch mark/support_swapped_axes_images for this task. While the region spectral profile, PV, and moments images need to fix too. Because the default ra and dec axis numbers are 0 and 1 in the backend. Considering to create another backend issue to fix it. To render a rotating cube as ra-channel or dec-channel images would be another issue too after the previous job is done.

@kswang1029
Copy link
Contributor Author

@kswang1029 Is it OK to load a swapped-axes cube and render it as ra-dec image for now? The backend needs to tell the frontend real axis numbers of ra, dec, spectral, and stokes axes. So the frontend can render a ra-dec image with the correct coordinate system (in AST setting). I have created a backend branch mark/1178_support_swapped_axes_images and a frontend branch mark/support_swapped_axes_images for this task. While the region spectral profile, PV, and moments images need to fix too. Because the default ra and dec axis numbers are 0 and 1 in the backend. Considering to create another backend issue to fix it. To render a rotating cube as ra-channel or dec-channel images would be another issue too after the previous job is done.

The main goal is to let the backend load a cube with the axes in any order and let the frontend render the first two axes as x and y and being able to animate in z.

@kswang1029
Copy link
Contributor Author

done via #1194

@confluence
Copy link
Collaborator

I'm reopening this issue because of the errors and crashes caused by hardcoded axes that we found during refactoring. Some of these will be fixed in #1389, but there is outstanding work to be done in the region code (which should be done in a separate PR once some of the refactoring which will make it easier has been merged).

@confluence confluence reopened this Nov 6, 2024
@confluence confluence assigned pford and unassigned markccchiang Nov 6, 2024
@kswang1029
Copy link
Contributor Author

Note: region analytics was descoped at the time. The main focus was simple raster view in the image viewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request requiring frontend this backend issue requires work in both frontend and backend
Projects
None yet
Development

No branches or pull requests

4 participants