Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YALB-1577: Fix time format on condensed events #453

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

nJim
Copy link
Contributor

@nJim nJim commented Oct 5, 2023

YALB-1577: Fix time format on condensed events

Description of work

  • Update the fields formatter to use 'plain' text instead of the 'smartdate' format. This ensure the time is passed to the component library in the correct format.

Functional testing steps:

  • Login as a site administrator
  • Create an event with a far future date. Save this event and make sure it is published.
  • Add a basic 'views' component to a page-node. The view should show all future events in a 'condensed' layout.
  • Save the page and view the content. Verify that the view displays events with the correct date for the event. Previously this was showing today's date for every event.

@nJim nJim self-assigned this Oct 5, 2023
@nJim nJim requested a review from dblanken-yale October 17, 2023 19:23
@github-actions
Copy link

Visit Site

Created multidev environment pr-453 for yalesites-platform.

Copy link
Contributor

@dblanken-yale dblanken-yale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome work. The dates are working just fine.

I did find this visual issue, although not sure it's appropriate for this ticket, so still accepting. Just documenting. :D

Screenshot 2023-10-18 at 10 25 27 AM

@nJim
Copy link
Contributor Author

nJim commented Oct 18, 2023

@dblanken-yale Thank you for the note. There are a few issues on the admin theme that we need to address. But we will come at it with a bigger plan later next month. This irks me, but is not a blocker. I will doucment it for when Joe returns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants