Release #520
Merged
Release #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th header and footer settings forms
… working on config
…ings form, add SVG uploader
* Disables links being present inside of quick link content fields * Converts any existing quick link blocks to remove link elements. * Reverts search_api_html_element_filter to use the main branch now that our patch was accepted into the main repository.
YALB-863: Set default value callbacks for all block dials
YALB-1577: Fix time format on condensed events
YALB-1579: Fixing theme form error messages
* feat: create and copy secrets file into lando container * feat: refactor local secrets handling per pantheon-secrets-sdk instructions * chore: bump composer platform php req to 8.1 * chore: update to php 8.2 to keep in sync with D10 work
* docs (YALB-1155): Add data model best practices do developer Readme file * docs (YALB-1154): Add documentation about dials
* feat(YALB-1472): enable area limits to imagemagick Even with the file limit, it still bases the memory on the area of the image (width * height * bits needed by imagemagick). By adding the area limit, if the width * height gets over 20 megapixels, it utilizes disk over memory. This does not mean that it'll load every time, but it now gives a chance for all of the images to finish. * feat(YALB-1472): memory and map needed For a successful image generation, memory/map limits are still needed. While having the area tells it when to use disk space to map, the mapping must be filling up and erroring still. While this does not ensure an image every time, it has usually worked on the 2nd try. * fix(YALB-1472): limit images to 4K resolution Given what was said by Pantheon, and the calculator provided, I thought we'd try to see how images would do limiting to the 4k resolution of 3840x2160 while leaving in our imagemagick limits in case somehow an image gets on the server that would cause it to error. This will give larger images a chance to load should they ever get on there while limiting the amount of memory needed for uploaded images. * feat(YALB-1472): add image conversion scripts In order for images to load properly, we made the decision to limit the width and height to a 4k display. There are sites out there that already have these larger images, and will not get resized. These are scripts to assist in handling this. - calculateMB.sh: returns the amount of memory an image will use to convert to our currently highest resolution - get_images.sh: retrieves all files (images) under the /files directory of a Pantheon site - put_images.sh: places all files (images) under a local directory to a directory on a Pantheon site - fix_images.sh: Evaluates all jpgs inside of a directory. If they are above the threshold that we desire of a width/height, it attempts to resize it in place. - doItAll.sh: My attempt to have one script that will retrieve images, convert them, and reupload them in one script (still a WIP)
* fix(YALB-1593): assign unique dom_id to views In Drupal, there is a mechanism that attemps to re-use pagers for views, usually because they are not used multiple times in a page. For those times they are, a patch was made to use the dom_id as a way to uniquely identify a view such that the pager will be unique. In our implementation, the dom_id of our view is never set, causing this to be skipped, and the pager ID to retain a value of 0, making it re-used across the page rendered. This fix assigns a unique dom_id to the view before it is built so that it will generate a unique pager instance per view. * fix(YALB-1593): apply dynamic pager ID patch This is the patch that enables the dom_id to produce a unique pager. References: https://www.drupal.org/project/drupal/issues/3225987 * fix(YALB-1593): remove c date format patch
…g from theme and core to new header settings
…demand rather than save function
… same as content spotlight
…atch regular content spotlight
…d-items YALB-959 min max referenced items
… and spotlight-portrait
Actions: update existing release PRs
…tent" in top menu (#530) * fix(YALB-1663): deleting default section does not error There was a problem where a user deleted the default content section. Upon saving this, they were unable to go back in to modify the page in layout builder. This was due to an access check issue in section_library. This patch fixes this so that the user could edit the page in layout builder again. * feat(YALB-1663): allow "Add Section" after Title and Metadata layout_builder_lock was disallowing sections to be added after the Title and Metadata section of a Page, or the bottom content section of a Profile. Since we are now allowing them to remove the default content section, they will need a way to add a new section, which this provides. "Add Section" is now displayed below in these cases.
We need the ability to set the environment dynamically when calling this script, so change to using a variable and fall back to dev if it isn't set.
feat: content on install to environments other than dev
YALB-1686: Allow rtf file uploads
…ghts YALB-1674: add new content spotlight portrait component | YALB-1675: Feedback: Content Spotlight - inline/offset image dial | YALB-1676: Feedback: Content Spotlight portrait image treatment
fix: update existing release PRs correctly without errors
fix: filter out merge commits that do not have a PR (actions create PR workflow)
…535) In updating develop from master, the allowed_formats were overwritten from before. This re-establishes this for new quicklink blocks.
fix: update jq condition to properly filter merge commits from diff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull requests
developfrommaster#518Changes without a pull request: