forked from yalesites-org/yalesites-project
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release #13
Closed
Closed
Release #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th header and footer settings forms
… working on config
…ings form, add SVG uploader
…rg#431) * Disables links being present inside of quick link content fields * Converts any existing quick link blocks to remove link elements. * Reverts search_api_html_element_filter to use the main branch now that our patch was accepted into the main repository.
…ults YALB-863: Set default value callbacks for all block dials
…nt-date-bug YALB-1577: Fix time format on condensed events
YALB-1579: Fixing theme form error messages
* feat: create and copy secrets file into lando container * feat: refactor local secrets handling per pantheon-secrets-sdk instructions * chore: bump composer platform php req to 8.1 * chore: update to php 8.2 to keep in sync with D10 work
* docs (YALB-1155): Add data model best practices do developer Readme file * docs (YALB-1154): Add documentation about dials
* feat(YALB-1472): enable area limits to imagemagick Even with the file limit, it still bases the memory on the area of the image (width * height * bits needed by imagemagick). By adding the area limit, if the width * height gets over 20 megapixels, it utilizes disk over memory. This does not mean that it'll load every time, but it now gives a chance for all of the images to finish. * feat(YALB-1472): memory and map needed For a successful image generation, memory/map limits are still needed. While having the area tells it when to use disk space to map, the mapping must be filling up and erroring still. While this does not ensure an image every time, it has usually worked on the 2nd try. * fix(YALB-1472): limit images to 4K resolution Given what was said by Pantheon, and the calculator provided, I thought we'd try to see how images would do limiting to the 4k resolution of 3840x2160 while leaving in our imagemagick limits in case somehow an image gets on the server that would cause it to error. This will give larger images a chance to load should they ever get on there while limiting the amount of memory needed for uploaded images. * feat(YALB-1472): add image conversion scripts In order for images to load properly, we made the decision to limit the width and height to a 4k display. There are sites out there that already have these larger images, and will not get resized. These are scripts to assist in handling this. - calculateMB.sh: returns the amount of memory an image will use to convert to our currently highest resolution - get_images.sh: retrieves all files (images) under the /files directory of a Pantheon site - put_images.sh: places all files (images) under a local directory to a directory on a Pantheon site - fix_images.sh: Evaluates all jpgs inside of a directory. If they are above the threshold that we desire of a width/height, it attempts to resize it in place. - doItAll.sh: My attempt to have one script that will retrieve images, convert them, and reupload them in one script (still a WIP)
…tes-org#462) * fix(YALB-1593): assign unique dom_id to views In Drupal, there is a mechanism that attemps to re-use pagers for views, usually because they are not used multiple times in a page. For those times they are, a patch was made to use the dom_id as a way to uniquely identify a view such that the pager will be unique. In our implementation, the dom_id of our view is never set, causing this to be skipped, and the pager ID to retain a value of 0, making it re-used across the page rendered. This fix assigns a unique dom_id to the view before it is built so that it will generate a unique pager instance per view. * fix(YALB-1593): apply dynamic pager ID patch This is the patch that enables the dom_id to produce a unique pager. References: https://www.drupal.org/project/drupal/issues/3225987 * fix(YALB-1593): remove c date format patch
…g from theme and core to new header settings
…demand rather than save function
…ple-header YALB-1574: Branding: Header Variations Backend
…alesites-org#491) * fix(YALB-1574): front page alias shows header This attempts to fix a bug that was found with the header implementation. isFrontPage does not seem to take into account aliases. We get around this by getting the node id of the page, the alias of the page, and the current front page that is set in site settings. We then determine if it is the front page if the location set in the site settings matches either the node id path or the alias path, or if isFrontPage thinks it's a front page. References: https://www.drupal.org/project/drupal/issues/1503146
Quick Node Clone does a great job of cloning, however, when it attempts to clone a node with layout builder, it does not correctly clone the inline blocks and paragraph references we use. This is a more global issue, and a patch has been worked on to fix this. This patch seems to fix our issue and sub-items are properly cloned and editable.
…ock-library YALB-1654: Reusable Content Prep: Remove or add message to block library
* feat(YALB-1586): initial commit of dependabot.yml * chore(YALB-1586): change dependabot frequency to monthly * chore(YALB-1586): pin versions for drupal core * feat(YALB-1586): add check in CI for unpinned dependencies * chore(YALB-1586): unpin drupal/multiple_fields_remove_button
…access to fix adding media to blocks. Also adds help text to custom block library page.
…g-fix YALB-1654: BUG FIX Reusable Content Prep: Remove or add message to block library
…-node-access-error YALB-1629 Fix node access warning
* fix: add css that sets a max-height on the editable area * fix: add line at eof * fix: update to css * fix: yalb-1429 set drupal displace variables rather than hardcode * fix: yalb-1429 added change to atomic upstream
…s-org#508) * feat(YALB-1306): add variation dial to text component * feat(YALB-1306): add variation dial to text component
…ign | YALB-1661 - Profile media image being used for page and view block | YALB-1662 - Mobile view profile list (yalesites-org#503) * fix(YALB-1660): create new responsive image style and update responsive image style for profile banner * fix(YALB-1660): add view mode for banner profile, adjust image sizes by breakpoint * feat(YALB-1661): Profile lists get the following images in order: teaser, profile image, fallback * fix(YALB-1660): update responsive image styles --------- Co-authored-by: Marc Berger <[email protected]>
…yalesites-org#495) * fix(YALB-1644): add field_alignment to callouts and ys_themes_allowed_values_function * fix(YALB-1644): add field_alignment options to overrides * fix(YALB-1644): add correct field variable * Update ys_themes.component_overrides.yml Change default: 'Center' to 'center' * Update ys_themes.component_overrides.yml Change default: 'Center' to 'center' * feat(YALB-1644): Add default value callback to callout alignment * feat(YALB-1644): Make alignment required to not allow none option --------- Co-authored-by: Marc Berger <[email protected]>
Update master from develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull requests
Additional changes