Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activity completion support, improved scoring and logging with GDPR support #43

Merged
merged 13 commits into from
Jun 25, 2018
Merged

Activity completion support, improved scoring and logging with GDPR support #43

merged 13 commits into from
Jun 25, 2018

Conversation

sbourget
Copy link
Collaborator

This patch resolves issue #22 and also partially implements #14. It also addresses everything in #39

It addresses the following:

Adds tracking of user scores. Uses AJAX to write the scores to the database.
Improves logging allowing teachers / admins to identify who has been using the module.
Implements the callbacks for the outline and complete reports now that we have data that can be viewed on the reports.
Implements course reset as now we have scores that can be cleared.
Implements a page for teachers etc to view all student scores.
Adds support for activity completion for both views and minimum score
Adds unit tests for the events
Fixes remaining travis issues (travis is now passing)
Adds support for the privacy API allowing users to export / request deletion of their data.

sbourget added 13 commits June 20, 2018 10:15
@sbourget
mod_quizgame: Implement user scores
5d997ca 
This commit includes:
1. An AJAX service to write player scores to the DB
2. The ability to clear user scores upon activity deletion & course
reset.
3. User scores now display on the user activity reports (complete &
outline)
4. Improved logging for user scores.

TODO:
1. Activity completion based on score
2. Logging based on gameplay start
3. Unit Tests
4. Getting travis to pass.
@sbourget
mod_quizgame: Get travis to Pass
5d07fc5 
Update travis.yml file to use v2 of the moodle-ci plugin
@sbourget
mod_quizgame: Add Activity completion support
0e19d15 
Adds support for both view and score based activity completion.
@sbourget
mod_quizgame: Log players when they start the game.
3479721
@sbourget
mod_quizgame: Add additional fields to backup / restore
6ef238b
@sbourget
mod_quizgame: Small code checker fixes
ff85f65
@sbourget
mod_quizgame: add quiz game generator & unit tests
b306ffc
@sbourget
mod_quizgame: Add unit tests for events.
edf614d
@sbourget
mod_quizgame: Allow teachers to view player scores.
2e31767
@sbourget
mod_quizgame: Truncate scores before calling web service.
4ca1d20 
With matching questions it is possible to get a score of 666.66667 with
will result in an exception since the database is expecting an integer.
@sbourget
mod_quizgame: fix typo in language string.
9307db8
@sbourget
mod_quizgame: fix debugging notice when using course reset.
007d0b7
@sbourget
mod_quizgame: Add GDPR support
58b2317
@sbourget sbourget mentioned this pull request Jun 20, 2018
Closed
@xow
Copy link
Owner

xow commented Jun 25, 2018

Thanks @sbourget looks great! Closes #14

@xow xow merged commit 6476202 into xow:master Jun 25, 2018
@xow
Copy link
Owner

xow commented Jun 25, 2018

Or at least the score saving part of #14. Highscores is not there for students. Could be up for debate whether that feature is needed anyway 🙂

@sbourget sbourget mentioned this pull request Jun 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbourget @xow