Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity completion support, improved scoring and logging #39

Closed
wants to merge 14 commits into from

Conversation

sbourget
Copy link
Collaborator

@sbourget sbourget commented Mar 8, 2018

This patch resolves issue #22 and also partially implements #14.

It addresses the following:

Adds tracking of user scores. Uses AJAX to write the scores to the database.
Improves logging allowing teachers / admins to identify who has been using the module.
Implements the callbacks for the outline and complete reports now that we have data that can be viewed on the reports.
Implements course reset as now we have scores that can be cleared.
Implements a page for teachers etc to view all student scores.
Adds support for activity completion for both views and minimum score
Adds unit tests for the events
Fixes remaining travis issues (travis is now passing)

This commit includes:
1. An AJAX service to write player scores to the DB
2. The ability to clear user scores upon activity deletion & course
reset.
3. User scores now display on the user activity reports (complete &
outline)
4. Improved logging for user scores.

TODO:
1. Activity completion based on score
2. Logging based on gameplay start
3. Unit Tests
4. Getting travis to pass.
Update travis.yml file to use v2 of the moodle-ci plugin
Adds support for both view and score based activity completion.
With matching questions it is possible to get a score of 666.66667 with
will result in an exception since the database is expecting an integer.
@xow
Copy link
Owner

xow commented Jun 20, 2018

@sbourget Is there any chance you'd be interested in continuing this work?

Scores are effected by GDPR as the users should be able to export and delete their scores

@sbourget
Copy link
Collaborator Author

Yes, I can work on implementing the Privacy API.
Is there anything else needed to allow this PR to be merged? (Other than fixing the version conflict?)

@sbourget
Copy link
Collaborator Author

@xow I just put together the GDPR support for this and updated the pull request as #43 (I had several conflicts attempting to update this PR, so it was easier to submit a new one.)

Let me know if there is anything else I can do to help move this issue along.

@xow
Copy link
Owner

xow commented Jun 21, 2018

Ah ok @sbourget should we close this one?

@sbourget
Copy link
Collaborator Author

Sure, lets close this one and hopefully finish this up in #43

@sbourget sbourget closed this Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants