-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activity completion support, improved scoring and logging #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes: 1. An AJAX service to write player scores to the DB 2. The ability to clear user scores upon activity deletion & course reset. 3. User scores now display on the user activity reports (complete & outline) 4. Improved logging for user scores. TODO: 1. Activity completion based on score 2. Logging based on gameplay start 3. Unit Tests 4. Getting travis to pass.
Update travis.yml file to use v2 of the moodle-ci plugin
Adds support for both view and score based activity completion.
With matching questions it is possible to get a score of 666.66667 with will result in an exception since the database is expecting an integer.
@xow, When you have a chance, can you take a look at this patch |
For some reason, github closed this pull request when I attempted to rebase one of the commits (fixing a whitespace issue) I've resubmitted the PR as #39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch resolves issue #22 and also partially implements #14.
It addresses the following: