TELESTION-460 Dashboard layout editor #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 14, 2024
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
pklaschka
force-pushed
the
01-14-TELESTION-460_Dashboard_layout_editor
branch
3 times, most recently
from
324b35f to
f7cca4b
Compare
pklaschka
force-pushed
the
01-12-Disallow_widgets_to_resize_based_on_their_content
branch
from
b3cd735 to
3ec4e61
Compare
Base automatically changed from
01-12-Disallow_widgets_to_resize_based_on_their_content
to
main
January 17, 2024 15:48
pklaschka
force-pushed
the
01-14-TELESTION-460_Dashboard_layout_editor
branch
from
f7cca4b to
f704a73
Compare
pklaschka
commented
Jan 17, 2024
frontend-react/src/lib/application/routes/dashboard-editor/layout-editor/util.tsx
Outdated
Show resolved
Hide resolved
pklaschka
force-pushed
the
01-14-TELESTION-460_Dashboard_layout_editor
branch
9 times, most recently
from
2419e1e to
e6c60f0
Compare
pklaschka
commented
Jan 19, 2024
frontend-react/src/lib/application/routes/dashboard-editor/layout-editor/README.md
Outdated
Show resolved
Hide resolved
pklaschka
commented
Jan 19, 2024
...react/src/lib/application/routes/dashboard-editor/layout-editor/components/layout-editor.tsx
Outdated
Show resolved
Hide resolved
pklaschka
force-pushed
the
01-14-TELESTION-460_Dashboard_layout_editor
branch
6 times, most recently
from
1156d48 to
31bb241
Compare
pklaschka
force-pushed
the
01-14-TELESTION-460_Dashboard_layout_editor
branch
8 times, most recently
from
40aef50 to
835d7fa
Compare
pklaschka
force-pushed
the
01-14-TELESTION-460_Dashboard_layout_editor
branch
from
835d7fa to
05e2707
Compare
pklaschka
commented
Jan 21, 2024
frontend-react/src/lib/application/routes/page-wrapper/page-wrapper.module.css
Show resolved
Hide resolved
pklaschka
commented
Jan 21, 2024
...react/src/lib/application/routes/dashboard-editor/layout-editor/model/layout-editor-model.ts
Outdated
Show resolved
Hide resolved
pklaschka
commented
Jan 21, 2024
...ication/routes/dashboard-editor/layout-editor/hooks/use-layout-editor-keyboard-shortcuts.tsx
Show resolved
Hide resolved
This was referenced Jan 24, 2024
pklaschka
force-pushed
the
01-14-TELESTION-460_Dashboard_layout_editor
branch
5 times, most recently
from
61d9145 to
0ee0c4e
Compare
fussel178
requested changes
Jan 26, 2024
frontend-react/src/lib/application/routes/dashboard-editor/dashboard-editor.tsx
Outdated
Show resolved
Hide resolved
frontend-react/src/lib/application/routes/page-wrapper/page-wrapper.module.css
Outdated
Show resolved
Hide resolved
A layout editor for dashboards to make them configurable by users. Interaction can be performed using both the mouse and the keyboard. Changes are handled completely independently from the UI, allowing for both an easier way to ensure invalid states cannot occur as well as testability. During the user interaction, no actual state changes are performed. Once the interaction finishes, the changes get interpreted to the closest possible state change and "committed" to the state, where (in compliance with any business logic) the changes are applied and, thus, updates in the UI. This also allows us to implement any interactions without absolute positioning and resize observers. Instead, the native CSS grid can be used. Due to the relative complexity and clear boundaries of this subsystem, a separate folder structure which also includes a `README.md` was created.
pklaschka
force-pushed
the
01-14-TELESTION-460_Dashboard_layout_editor
branch
from
0ee0c4e to
81b92d9
Compare
fussel178
approved these changes
Jan 26, 2024
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A layout editor for dashboards to make them configurable by users.
Interaction can be performed using both the mouse and the keyboard.
Changes are handled completely independently from the UI, allowing for both an easier way to ensure invalid states cannot occur as well as testability. During the user interaction, no actual state changes are performed. Once the interaction finishes, the changes get interpreted to the closest possible state change and "committed" to the state, where (in compliance with any business logic) the changes are applied and, thus, updates in the UI. This also allows us to implement any interactions without absolute positioning and resize observers. Instead, the native CSS grid can be used.
Due to the relative complexity and clear boundaries of this subsystem, a separate folder structure which also includes a
README.mdwas created.Screenshot