Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TELESTION-443: Error Boundaries #411

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

pklaschka
Copy link
Member

@pklaschka pklaschka commented Jan 11, 2024

Implements a basic error boundary based on the react-error-boundary library.

The library is recommended by the official React documentation itself.

The PR also includes a default widget that throws an error for testing.

Note that the exact look and feel of the fallback component is considered out-of-scope for this PR and should be revisited at a later date.

Screenshot

localhost_5173_dashboards_sdjo8242.png

@pklaschka pklaschka requested a review from fussel178 January 11, 2024 23:15
@pklaschka pklaschka added 🌷 enhancement New feature or request 📚 library labels Jan 11, 2024
@pklaschka pklaschka self-assigned this Jan 11, 2024
@pklaschka pklaschka force-pushed the 01-12-TELESTION-443_Error_Boundaries branch from 1a24472 to 10a3901 Compare January 12, 2024 12:04
@pklaschka pklaschka marked this pull request as ready for review January 12, 2024 12:06
Copy link
Member

@fussel178 fussel178 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👓

@pklaschka pklaschka merged commit 9808011 into main Jan 17, 2024
17 checks passed
@pklaschka pklaschka deleted the 01-12-TELESTION-443_Error_Boundaries branch January 17, 2024 15:46
Copy link
Member Author

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌷 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants