Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow widgets to resize based on their content #412

Merged

Conversation

pklaschka
Copy link
Member

Previously, widget sizes would vary baased on the content.

Cf. https://www.w3.org/TR/css3-grid-layout/#min-size-auto – by adding overflow: auto to the widget containers, they become scroll containers (the grid items) and their "automatic minimum size is zero, as usual".

Thanks to https://stackoverflow.com/a/43312314/9276604 for the hint!

@pklaschka pklaschka requested a review from fussel178 January 12, 2024 12:05
@pklaschka pklaschka added the 🌷 enhancement New feature or request label Jan 12, 2024
@pklaschka pklaschka self-assigned this Jan 12, 2024
Copy link
Member

@fussel178 fussel178 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍺

Base automatically changed from 01-12-TELESTION-443_Error_Boundaries to main January 17, 2024 15:46
@pklaschka pklaschka force-pushed the 01-12-Disallow_widgets_to_resize_based_on_their_content branch from b3cd735 to 3ec4e61 Compare January 17, 2024 15:47
Copy link
Member Author

pklaschka commented Jan 17, 2024

Merge activity

  • Jan 17, 4:47 PM: Graphite rebased this pull request as part of a merge.
  • Jan 17, 4:48 PM: @pklaschka merged this pull request with Graphite.

@pklaschka pklaschka merged commit 26a60de into main Jan 17, 2024
17 checks passed
@pklaschka pklaschka deleted the 01-12-Disallow_widgets_to_resize_based_on_their_content branch January 17, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌷 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants