Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RWC2018 #101
RWC2018 #101
Changes from 61 commits
1efdb80
8bc7dbd
8634596
9bc40ac
aa0a7a5
ab09656
45bf1c4
d6783bd
54935de
4e576a3
52d19e8
6aeae01
d3f1558
7d4c6b0
1058c35
9b86b6d
9faac8f
d0eec6c
efa2756
15530cb
19e8505
24df4ca
e84923e
95868d0
2b0105c
22e1eb1
7bf04d4
53ecffe
a517a5c
bef6633
3d83c03
b30e9ed
878056c
455d346
086eb95
db310c8
26feed1
97c620a
2d7daee
cb1291f
88c37fe
0da360e
d6e4cc9
61ea670
cdfd4cc
ecb697a
4bfc3fb
e156223
0d05ff7
2800114
fc61eec
dd32a30
61bc8e0
e6951de
1ee9d46
0688eec
ba5e264
004250e
2e89756
688224c
dccac75
d56823b
1048326
3d55154
d72d58e
8446ebf
1ac2563
c0144a6
f67e837
9131e7c
8715110
d853180
37ac1d2
7244973
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The behavior implementation above should be moved to the smach states, but I would leave it for this PR and fx it in a refactor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue #96
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be placed in a separate testing script? @MatthijsBurgh @jlunenburg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I indeed prefer putting these tests (and hence the entire
__main__
) in a separate test file. It's good though that there's a good and easy way to test it!