Support method chaining in forage Logger #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 24, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @devinmorgan and the rest of your teammates on |
This was referenced Jun 24, 2024
Merged
devinmorgan
requested review from
owenkim,
ForageRob,
dleis612,
djoksimo and
evanfreeze
as code owners
devinmorgan
force-pushed
the
devin/simplify-pin-text-watcher
branch
from
4d9ed7f to
92f75e6
Compare
devinmorgan
force-pushed
the
devin/method-chaining-in-forage-logger
branch
from
259dfbc to
e383a62
Compare
Merged
djoksimo
approved these changes
Jun 27, 2024
devinmorgan
force-pushed
the
devin/simplify-pin-text-watcher
branch
from
92f75e6 to
a4d0ae1
Compare
method chaining can help reduce code verbosity so it's a nice quality of life improvement that the pos repo already has Signed-off-by: Devin Morgan <[email protected]>
devinmorgan
force-pushed
the
devin/method-chaining-in-forage-logger
branch
from
e383a62 to
39eac6b
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Logmethod now returns the current instance (this).Loginterface to reflect this change.Why
This change allows for a fluent interface when using the
Logmethods, making the logging implementation more expressive and chaining multiple log actions in a more concise way.Test Plan
Demo
N/A implementation detail
How
I've marked this PR to merge once eligibility