Move LD facilities into /ecom #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @devinmorgan and the rest of your teammates on |
This was referenced Jun 24, 2024
Merged
devinmorgan
requested review from
owenkim,
ForageRob,
dleis612,
djoksimo and
evanfreeze
as code owners
djoksimo
requested changes
Jun 24, 2024
...rc/main/java/com/joinforage/forage/android/core/services/forageapi/polling/PollingService.kt
Outdated
Show resolved
Hide resolved
devinmorgan
changed the base branch from
devin/rename-forage-sub-dir-to-rosetta
to
main
The Pos SDK does not use these; in fact we dropped LD from the Pos repo a long time ago
devinmorgan
force-pushed
the
devin/move-ld-service-to-ecom
branch
from
12e3223 to
38844f8
Compare
Merged
djoksimo
approved these changes
Jul 9, 2024
Merge activity
|
devinmorgan
added a commit
that referenced
this pull request
Jan 3, 2025
* Move LD facilities into /ecom The Pos SDK does not use these; in fact we dropped LD from the Pos repo a long time ago * Make temp polling variable internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
LDManagerand related LaunchDarkly functionality from the core services to the Ecom services.Why
Only the Ecom repo uses LD. To reflect this truth, the LD service needs to live in
/ecominstead of/coreTest Plan
Demo
N/A just implementation details
How
I've marked this PR to merge when ready