Rename ecom/ui/vault/forage -> ecom/ui/vault/rosetta #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of the moving parts use the prefix rosetta instead of forage. For example: * RosettaPinElement * RosettaPinSubmitter etc. Also, calling an implementation detail "forage" is unproductive because all the implementation details are forage-related Signed-off-by: Devin Morgan <[email protected]>
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @devinmorgan and the rest of your teammates on |
This was referenced Jun 24, 2024
Merged
devinmorgan
requested review from
owenkim,
ForageRob,
dleis612,
djoksimo and
evanfreeze
as code owners
Merge activity
|
Merged
devinmorgan
added a commit
that referenced
this pull request
Jan 3, 2025
All of the moving parts use the prefix rosetta instead of forage. For example: * RosettaPinElement * RosettaPinSubmitter etc. Also, calling an implementation detail "forage" is unproductive because all the implementation details are forage-related Signed-off-by: Devin Morgan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Rename ecom/ui/vault/forage -> ecom/ui/vault/rosetta
Why
All of the moving parts use the prefix rosetta instead of forage. For example:
RosettaPinElementRosettaPinSubmitteretc.
Also, calling an implementation detail "forage" is unproductive because all the implementation details are forage-relate
Test Plan
Demo
N/A this is an implementation detail
How
I've marked this PR to merge when ready