chore(blockifier): rename the getters for the gas prices struct

[ArniStarkware]

No description provided.

[reviewable-StarkWare]

This change is 

[ArniStarkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• chore(blockifier): move block info to starknet api #2246 : 2 dependent PRs (#2230 , #2237 )
• chore(blockifier): move GasPrices to snapi #2245
• feat(blockifier): derive serialize for block info #2244
• chore(blockifier): rename the getters for the gas prices struct #2269 👈 (View in Graphite)
• chore(blockifier): separate create and validate logic on gas prices #2243
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload workflows:

• Started at 2024-11-25T11:42:59Z
• Started at 2024-11-25T11:46:57Z
• Started at 2024-11-25T11:49:53Z
• Started at 2024-11-25T14:44:28Z
• Started at 2024-11-25T14:56:54Z

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (arni/gas_prices/separate_new_from_validate@7d6ad29). Learn more about missing BASE report.

Additional details and impacted files

@@                              Coverage Diff                              @@
##             arni/gas_prices/separate_new_from_validate    #2269   +/-   ##
=============================================================================
  Coverage                                              ?   64.05%           
=============================================================================
  Files                                                 ?      143           
  Lines                                                 ?    17922           
  Branches                                              ?    17922           
=============================================================================
  Hits                                                  ?    11480           
  Misses                                                ?     5647           
  Partials                                              ?      795           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[alonh5]

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

[alonh5]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware and @dorimedini-starkware)

---

crates/blockifier/src/transaction/account_transactions_test.rs line 1054 at r1 (raw file):

        (steps_per_l1_gas
            * max_fee
                .checked_div(block_context.block_info.gas_prices.l1_gas_price(&FeeType::Eth),)

When the call is trivial, it's better to access the field directly instead of using this method.

Code quote:

gas_prices.l1_gas_price(&FeeType::Eth)

[ArniStarkware]

Reviewable status: 8 of 10 files reviewed, 1 unresolved discussion (waiting on @alonh5 and @dorimedini-starkware)

---

crates/blockifier/src/transaction/account_transactions_test.rs line 1054 at r1 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

When the call is trivial, it's better to access the field directly instead of using this method.

Done.