chore(batcher): remove block metadata member from block builder factory

[ArniStarkware]

Refactor towards getting block info from consensus.

[reviewable-StarkWare]

This change is 

[ArniStarkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• chore(batcher): add next_block_info method to block builder factory #2231
• chore(batcher): remove block metadata member from block builder factory #2230 👈 (View in Graphite)
• chore(blockifier): move block info to starknet api #2246 : 1 other dependent PR (#2237 )
• chore(blockifier): move GasPrices to snapi #2245
• feat(blockifier): derive serialize for block info #2244
• chore(blockifier): rename the getters for the gas prices struct #2269
• chore(blockifier): separate create and validate logic on gas prices #2243
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov]

Codecov Report

Attention: Patch coverage is 26.66667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 5.18%. Comparing base (77a2f11) to head (a33b3cc).

Files with missing lines	Patch %	Lines
crates/starknet_batcher/src/block_builder.rs	0.00%	11 Missing ⚠️

Additional details and impacted files

@@                        Coverage Diff                        @@
##           arni/block_info/move_to_snapi   #2230       +/-   ##
=================================================================
- Coverage                          55.04%   5.18%   -49.86%     
=================================================================
  Files                                232     146       -86     
  Lines                              26264   16981     -9283     
  Branches                           26264   16981     -9283     
=================================================================
- Hits                               14456     880    -13576     
- Misses                             10789   16027     +5238     
+ Partials                            1019      74      -945     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[Yael-Starkware]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5 and @dafnamatsry)

[alonh5]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)

[github-actions]

Artifacts upload workflows:

• Started at 2024-11-24T14:49:41Z

[alonh5]

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware, @dafnamatsry, and @Yael-Starkware)

---

a discussion (no related file):
Is this PR still relevant? Instead of removing this here and then adding the block info (which contains these fields), you can just replace it in the same PR.

[ArniStarkware]

Previously, alonh5 (Alon Haramati) wrote…

Is this PR still relevant? Instead of removing this here and then adding the block info (which contains these fields), you can just replace it in the same PR.

This Pr is indeed no longer relevant.

[ArniStarkware]

This PR is no longer relevant.