chore(batcher): add block info to block proposal input

[ArniStarkware]

No description provided.

[reviewable-StarkWare]

This change is 

[ArniStarkware]

• chore(batcher): use block info to create block info #2238 : 2 dependent PRs (#2267 , #2302 )
• chore(consensus): set proposer address in propose block input #2346
• chore(batcher): set use_kzg_da flag in build block input #2345
• chore(batcher): set block timestamp in build block input #2342
• chore(batcher): set temp gas prices in propose block input #2341
• chore(batcher): verify block number on propose block #2340
• chore(batcher): add height as input #2339
• chore(batcher): add block info to block proposal input #2237 👈 (View in Graphite)
• chore(blockifier): move block info to starknet api #2246 : 1 other dependent PR (#2230 )
• chore(blockifier): move GasPrices to snapi #2245
• feat(blockifier): derive serialize for block info #2244
• chore(blockifier): rename the getters for the gas prices struct #2269
• chore(blockifier): separate create and validate logic on gas prices #2243
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload triggered. View details here

[codecov]

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 18.37%. Comparing base (e3165c4) to head (f632fef).
Report is 633 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/starknet_api/src/block.rs	0.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2237       +/-   ##
===========================================
- Coverage   40.10%   18.37%   -21.74%     
===========================================
  Files          26      190      +164     
  Lines        1895    24158    +22263     
  Branches     1895    24158    +22263     
===========================================
+ Hits          760     4439     +3679     
- Misses       1100    19337    +18237     
- Partials       35      382      +347     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Yael-Starkware]

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @alonh5, @ArniStarkware, and @dafnamatsry)

---

crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs line 119 at r1 (raw file):

            }),
            // TODO: Fill thin block info.
            thin_block_info: Default::default(),

I think the code will be simpler if consensus passed the entire block_info and we check on our side that the height of the block_info equals the height we are currently working on.

Code quote:

thin_block_info

[dafnamatsry]

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @alonh5 and @Yael-Starkware)

---

crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs line 119 at r1 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

I think the code will be simpler if consensus passed the entire block_info and we check on our side that the height of the block_info equals the height we are currently working on.

+1

[alonh5]

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @dafnamatsry and @Yael-Starkware)

---

crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs line 119 at r1 (raw file):

Previously, dafnamatsry wrote…

+1

👍

[ArniStarkware]

crates/starknet_batcher_types/src/batcher_types.rs line 40 at r1 (raw file):

    // TODO: Should we get the gas price here?
    // TODO: add proposer address.
    // TODO: add whether the kzg mechanism is used for DA.

@yair-starkware This is where the next_block_info is first created, later to be used in the batcher's block builder factory. See this discussion: https://reviewable.io/reviews/starkware-libs/sequencer/2238#-OCSG6aO--m1mxj5ypZi

Code quote:

    // TODO: Should we get the gas price here?
    // TODO: add proposer address.
    // TODO: add whether the kzg mechanism is used for DA.

[ArniStarkware]

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @alonh5, @dafnamatsry, and @Yael-Starkware)

---

crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs line 119 at r1 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

👍

Done.

[alonh5]

Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ArniStarkware, @dafnamatsry, and @Yael-Starkware)

---

crates/starknet_batcher_types/src/batcher_types.rs line 38 at r2 (raw file):

    pub deadline: chrono::DateTime<Utc>,
    pub retrospective_block_hash: Option<BlockHashAndNumber>,
    // TODO: Fill block info.

One TODO in the consensus is enough, you can remove these two.

Code quote:

// TODO: Fill block info.

---

crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs line 177 at r2 (raw file):

                hash: BlockHash::default(),
            }),
            // TODO: Fill thin block info.

Suggestion:

// TODO: Fill block info.

[ArniStarkware]

Reviewable status: 3 of 5 files reviewed, 3 unresolved discussions (waiting on @alonh5, @dafnamatsry, and @Yael-Starkware)

---

crates/starknet_batcher_types/src/batcher_types.rs line 38 at r2 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

One TODO in the consensus is enough, you can remove these two.

Done.

---

crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs line 177 at r2 (raw file):

                hash: BlockHash::default(),
            }),
            // TODO: Fill thin block info.

Done.

[github-actions]

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.803 ms 35.285 ms 35.842 ms]
change: [+1.2508% +2.6521% +3.9754%] (p = 0.00 < 0.05)
Performance has regressed.
Found 14 outliers among 100 measurements (14.00%)
3 (3.00%) high mild
11 (11.00%) high severe

[github-actions]

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [35.036 ms 35.529 ms 36.105 ms]
change: [+1.1281% +2.4986% +4.2442%] (p = 0.00 < 0.05)
Performance has regressed.
Found 10 outliers among 100 measurements (10.00%)
10 (10.00%) high severe

[alonh5]

Reviewed 2 of 2 files at r7, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)