Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add romanisim to downstream #530

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

WilliamJamieson
Copy link
Collaborator

Add romanisim to downstream testing.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.42%. Comparing base (9cd8552) to head (60de350).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #530   +/-   ##
=======================================
  Coverage   87.42%   87.42%           
=======================================
  Files          22       22           
  Lines        3874     3874           
=======================================
  Hits         3387     3387           
  Misses        487      487           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@WilliamJamieson WilliamJamieson force-pushed the ci/romanisim branch 4 times, most recently from c88bd37 to 060aa5d Compare November 19, 2024 19:14
@zacharyburnett
Copy link
Collaborator

zacharyburnett commented Nov 19, 2024

https://github.com/spacetelescope/gwcs/actions/runs/11920127584/job/33221427859?pr=530#step:10:2280

PytestUnknownMarkWarning: Unknown pytest.mark.soctests - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
    @pytest.mark.soctests

It looks to me like this is due to pytest initializing within the gwcs source directory, with its pytest config that doesn't include the soctests mark, and then moving to the romanisim package to DISCOVER the tests, but not having the marks registered. Can we explicitly checkout romanisim first in tox and start pytest from there somehow? Another solution could be having a dedicated workflow job for this downstream test without using tox or the OpenAstronomy workflow

@braingram
Copy link
Collaborator

https://github.com/spacetelescope/gwcs/actions/runs/11920127584/job/33221427859?pr=530#step:10:2280

PytestUnknownMarkWarning: Unknown pytest.mark.soctests - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
    @pytest.mark.soctests

It looks to me like this is due to pytest initializing within the gwcs source directory, with its pytest config that doesn't include the soctests mark, and then moving to the romanisim package to DISCOVER the tests, but not having the marks registered. Can we explicitly checkout romanisim first in tox and start pytest from there somehow? Another solution could be having a dedicated workflow job for this downstream test without using tox or the OpenAstronomy workflow

stcal had this issue to. Checking out the downstream and running from within the checkout allows pytest to find the configuration for the downstream package (instead of the gwcs one). See spacetelescope/stcal#297

@zacharyburnett zacharyburnett force-pushed the ci/romanisim branch 3 times, most recently from 7e884f2 to d7ab67e Compare November 20, 2024 18:40
@zacharyburnett zacharyburnett force-pushed the ci/romanisim branch 5 times, most recently from 9391580 to 2d8540c Compare November 20, 2024 20:23
@zacharyburnett zacharyburnett merged commit 5f66522 into spacetelescope:master Nov 20, 2024
31 checks passed
@WilliamJamieson WilliamJamieson deleted the ci/romanisim branch November 20, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants