Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some updates to the tox config #429

Merged
merged 8 commits into from
Nov 25, 2024

Conversation

WilliamJamieson
Copy link
Collaborator

@WilliamJamieson WilliamJamieson commented Nov 22, 2024

This PR updates the tox config slightly so that it works with tox-uv.

Tasks

  • Update or add relevant roman_datamodels tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@WilliamJamieson WilliamJamieson requested a review from a team as a code owner November 22, 2024 18:38
@WilliamJamieson WilliamJamieson requested review from zacharyburnett and removed request for a team November 22, 2024 18:38
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.37%. Comparing base (087a60d) to head (9a72f84).
Report is 78 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #429      +/-   ##
==========================================
- Coverage   97.56%   97.37%   -0.19%     
==========================================
  Files          30       37       +7     
  Lines        2788     3316     +528     
==========================================
+ Hits         2720     3229     +509     
- Misses         68       87      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WilliamJamieson WilliamJamieson added the Weekly CI Run the weekly scheduled CI label Nov 22, 2024
@WilliamJamieson WilliamJamieson force-pushed the cleanup_tox branch 2 times, most recently from a50cf97 to 3ee452c Compare November 22, 2024 21:23
@WilliamJamieson WilliamJamieson force-pushed the cleanup_tox branch 2 times, most recently from 4cd895f to be9dbb9 Compare November 22, 2024 21:41
tox.ini Outdated Show resolved Hide resolved
@WilliamJamieson WilliamJamieson force-pushed the cleanup_tox branch 5 times, most recently from 194ead5 to 9792e83 Compare November 22, 2024 22:42
tox.ini Outdated Show resolved Hide resolved
@WilliamJamieson WilliamJamieson force-pushed the cleanup_tox branch 2 times, most recently from 8188e70 to e1f6793 Compare November 22, 2024 23:17
@braingram
Copy link
Collaborator

What are the benefits of tox-uv? Given that uv isn't at 1.0.0 I'm hesitant to start using it in the CI.

Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. One requested change related to the minimum dependencies testing.

tox.ini Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@WilliamJamieson WilliamJamieson force-pushed the cleanup_tox branch 2 times, most recently from 4c81691 to e801f9a Compare November 25, 2024 17:46
Copy link
Collaborator

@zacharyburnett zacharyburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@WilliamJamieson WilliamJamieson merged commit ff946ba into spacetelescope:main Nov 25, 2024
20 checks passed
@WilliamJamieson WilliamJamieson deleted the cleanup_tox branch November 25, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed Weekly CI Run the weekly scheduled CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants