Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow data workflows (WebbPSF + GALSIM) to be used by upstream repos for downstream testing #176

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Nov 20, 2024

we're attempting to test romanisim as part of gwcs's downstream testing, and it would be very useful to be able to use this workflow to set up the webbpsf + GALSIM data cache for there:

This involves adding the workflow_call trigger and also allowing the user to specify the download path for the data

@zacharyburnett zacharyburnett self-assigned this Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.04%. Comparing base (81028a8) to head (7facf28).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
+ Coverage   89.24%   91.04%   +1.80%     
==========================================
  Files          17       16       -1     
  Lines        2073     2100      +27     
==========================================
+ Hits         1850     1912      +62     
+ Misses        223      188      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@zacharyburnett zacharyburnett force-pushed the ci/abstract_data branch 4 times, most recently from e48dfaa to 03760e3 Compare November 20, 2024 16:15
…for downstream testing

allow user to specify cache path

don't assume cache path

fix context availability

force /tmp/data for compatibility with macOS

add descriptive job name

rename outputs

ls directory

fix outputs
@zacharyburnett zacharyburnett marked this pull request as ready for review November 20, 2024 17:50
@zacharyburnett zacharyburnett requested a review from a team as a code owner November 20, 2024 17:50
Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me, and tests are passing.

@zacharyburnett zacharyburnett merged commit 53b9d03 into spacetelescope:main Nov 20, 2024
22 checks passed
@zacharyburnett zacharyburnett deleted the ci/abstract_data branch November 20, 2024 18:17
eunkyuh pushed a commit to eunkyuh/romanisim that referenced this pull request Dec 2, 2024
…for downstream testing (spacetelescope#176)

allow user to specify cache path

don't assume cache path

fix context availability

force /tmp/data for compatibility with macOS

add descriptive job name

rename outputs

ls directory

fix outputs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants