Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(experimental): nit: rename define to describe #2384

Merged
merged 1 commit into from
Mar 27, 2024
Merged

refactor(experimental): nit: rename define to describe #2384

merged 1 commit into from
Mar 27, 2024

Conversation

lorisleiva
Copy link
Contributor

@lorisleiva lorisleiva commented Mar 26, 2024 •
edited
Loading

Whilst working on this stack I realised I used the word [DEFINE] in comments to mimic the Jest structure but what I meant to write was actually [DESCRIBE]. This PR fixes this.

@lorisleiva lorisleiva mentioned this pull request Mar 26, 2024
Merged
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 26, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7a97dce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

This was referenced Mar 26, 2024
Merged
Merged
@lorisleiva Graphite App
Copy link
Contributor Author

lorisleiva commented Mar 26, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lorisleiva and the rest of your teammates on Graphite Graphite

@lorisleiva lorisleiva mentioned this pull request Mar 26, 2024
Merged
@mergify mergify bot added the community label Mar 26, 2024
@mergify mergify bot requested a review from a team March 26, 2024 17:28
@lorisleiva lorisleiva marked this pull request as ready for review March 26, 2024 17:35
@lorisleiva lorisleiva force-pushed the loris/rename-scalar-enum branch from 2d9c86b to 40777cc Compare March 26, 2024 17:37
@lorisleiva lorisleiva force-pushed the loris/define-describe branch from 34f967f to 5f55180 Compare March 26, 2024 17:37
@lorisleiva lorisleiva self-assigned this Mar 26, 2024
steveluscher
steveluscher approved these changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added via Giphy

@lorisleiva lorisleiva force-pushed the loris/rename-scalar-enum branch from 40777cc to 46f10af Compare March 27, 2024 09:17
@lorisleiva lorisleiva force-pushed the loris/define-describe branch from 5f55180 to bd0f27a Compare March 27, 2024 09:17
@lorisleiva Graphite App
Copy link
Contributor Author

lorisleiva commented Mar 27, 2024 •
edited
Loading

Merge activity

  • Mar 27, 9:34 AM EDT: @lorisleiva started a stack merge that includes this pull request via Graphite.
  • Mar 27, 9:41 AM EDT: Graphite rebased this pull request as part of a merge.
  • Mar 27, 9:42 AM EDT: @lorisleiva merged this pull request with Graphite.

@lorisleiva lorisleiva force-pushed the loris/rename-scalar-enum branch from 46f10af to 9f72428 Compare March 27, 2024 13:38
Base automatically changed from loris/rename-scalar-enum to master March 27, 2024 13:39
@lorisleiva lorisleiva force-pushed the loris/define-describe branch from bd0f27a to 7a97dce Compare March 27, 2024 13:40
@lorisleiva lorisleiva merged commit 5b21c65 into master Mar 27, 2024
6 checks passed
@lorisleiva lorisleiva deleted the loris/define-describe branch March 27, 2024 13:42
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 1, 2024

🎉 This PR is included in version 1.91.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steveluscher steveluscher steveluscher approved these changes

@mcintyre94 mcintyre94 Awaiting requested review from mcintyre94

@buffalojoec buffalojoec Awaiting requested review from buffalojoec

Assignees

@lorisleiva lorisleiva

Labels
community released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lorisleiva @steveluscher