Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(experimental): rename getDataEnumCodec to getDiscriminatedUnionCodec #2382

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

lorisleiva
Copy link
Contributor

@lorisleiva lorisleiva commented Mar 26, 2024

This PR renames the concept of a "Data Enum" to what it actually is: a "Discriminated Union".

See #2296.

Copy link

changeset-bot bot commented Mar 26, 2024

🦋 Changeset detected

Latest commit: d7fc933

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@solana/codecs-data-structures Patch
@solana/codecs-core Patch
@solana/codecs Patch
@solana/errors Patch
@solana/transactions Patch
@solana/accounts Patch
@solana/addresses Patch
@solana/codecs-numbers Patch
@solana/codecs-strings Patch
@solana/keys Patch
@solana/options Patch
@solana/rpc-api Patch
@solana/rpc-types Patch
@solana/web3.js-experimental Patch
@solana/sysvars Patch
@solana/assertions Patch
@solana/compat Patch
@solana/instructions Patch
@solana/rpc-spec Patch
@solana/rpc-subscriptions-spec Patch
@solana/rpc-subscriptions-transport-websocket Patch
@solana/rpc-subscriptions Patch
@solana/rpc-transport-http Patch
@solana/rpc Patch
@solana/signers Patch
@solana/transaction-confirmation Patch
@solana/web3.js-legacy-sham Patch
@solana/programs Patch
@solana/rpc-graphql Patch
@solana/rpc-subscriptions-api Patch
@solana/rpc-parsed-types Patch
@solana/rpc-transformers Patch
@solana/functional Patch
@solana/rpc-spec-types Patch
@solana/webcrypto-ed25519-polyfill Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

giphy.gif

@lorisleiva lorisleiva force-pushed the loris/data-enum-custom-discriminator-value branch from 4f9a7da to 1195521 Compare March 27, 2024 09:17
@lorisleiva lorisleiva force-pushed the loris/rename-data-enum branch from 4997976 to 360fa61 Compare March 27, 2024 09:17
Copy link
Contributor Author

lorisleiva commented Mar 27, 2024

Merge activity

  • Mar 27, 9:34 AM EDT: @lorisleiva started a stack merge that includes this pull request via Graphite.
  • Mar 27, 9:36 AM EDT: Graphite rebased this pull request as part of a merge.
  • Mar 27, 9:37 AM EDT: @lorisleiva merged this pull request with Graphite.

@lorisleiva lorisleiva force-pushed the loris/data-enum-custom-discriminator-value branch from 1195521 to f29af61 Compare March 27, 2024 13:34
Base automatically changed from loris/data-enum-custom-discriminator-value to master March 27, 2024 13:35
@lorisleiva lorisleiva force-pushed the loris/rename-data-enum branch from 360fa61 to d7fc933 Compare March 27, 2024 13:35
@lorisleiva lorisleiva merged commit 7e86583 into master Mar 27, 2024
6 checks passed
@lorisleiva lorisleiva deleted the loris/rename-data-enum branch March 27, 2024 13:37
Copy link
Contributor

github-actions bot commented Apr 1, 2024

🎉 This PR is included in version 1.91.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants