-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(experimental): support custom discriminator property for getDataEnumCodec #2380
refactor(experimental): support custom discriminator property for getDataEnumCodec #2380
Conversation
🦋 Changeset detectedLatest commit: a8084d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
['B', {} as Encoder<{ x: number; y: number }>], | ||
]) satisfies Encoder<{ __kind: 'A'; value: string } | { __kind: 'B'; x: number; y: number }>; | ||
} | ||
// It constructs data enums from a list of encoder variants. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kinobi PR ready to follow this up at: metaplex-foundation/kinobi#187 |
Merge activity
|
🎉 This PR is included in version 1.91.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
This PR adds support for custom discriminator properties for
getDataEnumCodecs
.Note that, to make this work, this PR updates a few exported types such as
GetDataEnumKind
orGetDataEnumKindContent
which is used by Kinobi. I'll make sure to have a PR ready on Kinobi's side when this is ready to be merged.