update IPUtils #10844
Merged
update IPUtils #10844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
Given that this is a direct copy from https://github.com/symfony/http-foundation/blob/6.3/IpUtils.php, and that the other methods also came from that package (albeit an early version of it), I'm okay with this change.
It's being added as part of silverstripe/silverstripe-session-manager#110 so I'll hold off merging until the PR that calls this method has been created.
It would obviously be ideal to deprecate this whole class and direct people to use the symfony package itself directly instead - I'll create a new issue for that as it's not in scope for this PR. (edit: #10846)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@GuySartorelli so this is the package i was talking about
ideally, it would be great to just use the new version entirely, but there are some subtle changes (like checkIP becoming checkIp... )
if at some point the symfony/http-foundation package is included, then this class can simply forward the static calls to the package class