Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDPR: Storing of IP Addresses / PI #110

Closed
christopherdarling opened this issue May 29, 2022 · 4 comments · Fixed by #161
Closed

GDPR: Storing of IP Addresses / PI #110

christopherdarling opened this issue May 29, 2022 · 4 comments · Fixed by #161

Comments

@christopherdarling
Copy link

christopherdarling commented May 29, 2022

Because we're storing the IP address of a logged in member (not just CMS members), has GDPR compliance been considered? I would have thought we should have a warning somewhere about this new functionality, maybe even just in the changelogs so people can update their privacy policy accordingly...

PRs

@maxime-rainville
Copy link

Off the top of my head, I don't remember us pondering this question. There is a task to periodically purge old sessions ... however I'm not sure to what degree this mitigates GDPR concerns.

This modules is somewhat CMS user focus. We didn't look at how this would impact users, that don't have back end access.

If your use case requires users to register to gain access to front end features, you probably have broader GDPR concerns that go beyond just logging IP addresses.

Our general approach has been to put compliance with local laws back on project owners ... which is admittedly unsatisfying. At the same time we are not lawyers and we can't possibly foresee all the possible interactions of use cases.

Steps we could take:

  • Provide explicit documentation to let project owners know about the IP address tracking implication of using this module,
  • Provide some alternative middleware that allows users without CMS access to bypass the session manager logic
  • Use a one way hashing function to hash the IP address before we store it in the DB. That might still be problematic because it allows us to finger print the user ... which is the entire point of storing the IP in the first place.

@lekoala
Copy link
Contributor

lekoala commented Jun 22, 2023

Ah i missed that one as well, never realized there was a task to clean this up... just added that feature in my simple-jobs module
https://github.com/lekoala/silverstripe-simple-jobs

I think it would be great to have at least a configuration option to avoid storing the ip, or allow anonymization of the ip
(eg: https://symfony.com/blog/new-in-symfony-4-4-ip-address-anonymizer)

@GuySartorelli
Copy link
Member

@lekoala Have you had a chance to look at creating a new PR for the anonymisation of the IP address? I'm happy with the IPUtils PR but I'm not going to merge it until there's something in a core or supported module that wants to use it.

@lekoala
Copy link
Contributor

lekoala commented Aug 3, 2023

@GuySartorelli yes it would go something like #161
didn't fully reviewed, but you can check if that suits you

i think it's less urgent than:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants