Add option to anonymize ip requests #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
requested changes
Aug 3, 2023
Co-authored-by: Guy Sartorelli <[email protected]>
Co-authored-by: Guy Sartorelli <[email protected]>
Co-authored-by: Guy Sartorelli <[email protected]>
Co-authored-by: Guy Sartorelli <[email protected]>
Co-authored-by: Guy Sartorelli <[email protected]>
Co-authored-by: Guy Sartorelli <[email protected]>
|
Thanks for making those changes. Looks like CI is angry about a missing semicolon, can you please fix that up? Otherwise this looks about ready to merge. |
GuySartorelli
requested changes
Aug 10, 2023
There was a problem hiding this comment.
Sorry, I should have noticed this earlier - but since this is using a method that's not going to be available until framework 5.1, please bump the constraint in composer.json for framework from ^5 to ^5.1
Other than that it looks good and works well locally, so once that's done I'll merge both PRs.
GuySartorelli
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires silverstripe/silverstripe-framework#10844
Fixes #110