-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG Display a notification after publishing a campaign #177
BUG Display a notification after publishing a campaign #177
Conversation
Might need to wrtie some unit test and behat test + bump dependencies. |
@maxime-rainville, seems to work, just need to update the text and fix travis. |
e717c08
to
1a14b83
Compare
Updated the messages and added some behat test. The behat test won't be green until the matching framework PR is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved from UX perspective.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just had a glance to see if we could sneak in a "successfully added" toast notification is this PR. Sadly, it looks non-trivial. The add to campaign logic is actually in admin for some weird reason. https://github.com/silverstripe/silverstripe-admin/blob/1/client/src/legacy/AddToCampaignForm.js |
e697076
to
c8f4b33
Compare
Added a follow up issue for "the add to campaign" modal #190 |
Use the new react toast notification to tell the user when their campaign has been published.
Parent issue
Depends on