FIX Update behat toast logic so it works with quotes #9770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cheddam
approved these changes
Nov 15, 2020
|
@maxime-rainville Might be best to hold off on merging this until |
maxime-rainville
force-pushed
the
pulls/4/allows-test-for-toast-with-quotes
branch
from
b7b1c72 to
c042f83
Compare
|
I've retargetted the PR to the 4.7 branch. |
maxime-rainville
force-pushed
the
pulls/4/allows-test-for-toast-with-quotes
branch
from
c042f83 to
92af6b3
Compare
maxime-rainville
deleted the
pulls/4/allows-test-for-toast-with-quotes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toast notification will often contain double quotes. This PR update our logic for testing toast notification in behat so it allows messages with double quotes.