Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User should receive a toast confirmation when publishing a campaign #131

Closed
newleeland opened this issue Jan 18, 2019 · 3 comments · Fixed by #177
Closed

User should receive a toast confirmation when publishing a campaign #131

newleeland opened this issue Jan 18, 2019 · 3 comments · Fixed by #177

Comments

@newleeland
Copy link

newleeland commented Jan 18, 2019

When a campaign is published there is no feedback for the user to confirm that their publishing action was successful.

A toast message like 'Published "[Campaign name]" successfully.' should be used

ACs

  • Finalise existing PR
  • Test and confirm functionality with PUX

PR

@clarkepaul
Copy link

I think the toast notification is okay for MVP but we should really design for a much nicer publish notification for campaigns.
I'm thinking we need to incorporate a loading indicator, and something more like a modal to say the campaign has been successfully launched, congratulations. This could also lead into actions which help you decide what to do next like "copy Campaign", but also provide some more details of the campaign e.g. How many items were published as part of the campaign.

@robbieaverill
Copy link
Contributor

@clarkepaul I'm happy to add a toast message in now if you'd like, but would you rather close this or wait until you have a design for future instead?

@clarkepaul
Copy link

clarkepaul commented Feb 4, 2019

@robbieaverill yeah that would be great to add a toast now. Cheers

I'm tracking some more design for this in our backlog which will come up with a more elaborate design (I've raised a separate GitHub issue for the more detailed experience #135).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment