Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hierarchical sampling with composite mass model #20

Merged
merged 95 commits into from
Dec 8, 2023

Conversation

ajshajib
Copy link
Collaborator

This PR adds the feature to consider a composite mass model in kinematic computation, for example, generalized NFW and stars.

@ajshajib
Copy link
Collaborator Author

ajshajib commented Nov 30, 2023

To-do list:

  • Implement conversion from Sersic light profile into MGE within hierArc.
  • Write test functions.
  • Extend LensLikelihood to interpolate kinematics computation for individual-level composite model parameters, with extensions of AnisotropyScalingIFU or similar new classes.

@ajshajib
Copy link
Collaborator Author

ajshajib commented Dec 1, 2023

@sibirrer, looks like pre-commit.ci is not inastalled for the repo. In that case, can you kindly do that?

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2023

Codecov Report

Merging #20 (1de5e4e) into main (56c660f) will increase coverage by 0.12%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   99.23%   99.35%   +0.12%     
==========================================
  Files          43       44       +1     
  Lines        1950     2182     +232     
==========================================
+ Hits         1935     2168     +233     
+ Misses         15       14       -1     
Files Coverage Δ
hierarc/LensPosterior/base_config.py 100.00% <100.00%> (ø)
hierarc/LensPosterior/kin_constraints.py 97.18% <ø> (ø)
hierarc/LensPosterior/kin_constraints_composite.py 100.00% <100.00%> (ø)
.../Likelihood/LensLikelihood/base_lens_likelihood.py 100.00% <100.00%> (ø)
...kelihood/LensLikelihood/ddt_dd_gauss_likelihood.py 100.00% <100.00%> (ø)
...Likelihood/LensLikelihood/ddt_dd_kde_likelihood.py 100.00% <100.00%> (ø)
...elihood/LensLikelihood/ddt_gauss_kin_likelihood.py 100.00% <100.00%> (ø)
...kelihood/LensLikelihood/ddt_hist_kin_likelihood.py 100.00% <100.00%> (ø)
...kelihood/LensLikelihood/ds_dds_gauss_likelihood.py 100.00% <100.00%> (ø)
...ierarc/Likelihood/LensLikelihood/kin_likelihood.py 98.11% <100.00%> (ø)
... and 5 more

@sibirrer
Copy link
Owner

sibirrer commented Dec 1, 2023

@sibirrer, looks like pre-commit.ci is not inastalled for the repo. In that case, can you kindly do that?

just did it @ajshajib

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ajshajib ajshajib marked this pull request as ready for review December 7, 2023 20:21
@ajshajib ajshajib requested a review from sibirrer December 7, 2023 20:22
Copy link
Owner

@sibirrer sibirrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ajshajib. Unfortunately I don't see a test coverage, but otherwise it good to go

@ajshajib
Copy link
Collaborator Author

ajshajib commented Dec 8, 2023

Thanks @sibirrer for approval, and also to @williyamshoe for his contributions! The test coverage is a little hidden to see, but it's here: https://app.codecov.io/gh/sibirrer/hierArc/pull/20. The above message from codecov, which auto-updated after the last commit, says that the new lines are 100% tested and overall coverage increased by 0.12%.

It also gives the notice, which may have to do with the coverage report being a little hard to find.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@sibirrer sibirrer merged commit 423e6d8 into sibirrer:main Dec 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants