-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hierarchical sampling with composite mass model #20
Conversation
To-do list:
|
@sibirrer, looks like pre-commit.ci is not inastalled for the repo. In that case, can you kindly do that? |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
==========================================
+ Coverage 99.23% 99.35% +0.12%
==========================================
Files 43 44 +1
Lines 1950 2182 +232
==========================================
+ Hits 1935 2168 +233
+ Misses 15 14 -1
|
just did it @ajshajib |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Adding test cases to composite mass modeling
… into feature/composite
… into feature/composite
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ajshajib. Unfortunately I don't see a test coverage, but otherwise it good to go
Thanks @sibirrer for approval, and also to @williyamshoe for his contributions! The test coverage is a little hidden to see, but it's here: https://app.codecov.io/gh/sibirrer/hierArc/pull/20. The above message from It also gives the notice, which may have to do with the coverage report being a little hard to find.
|
This PR adds the feature to consider a composite mass model in kinematic computation, for example, generalized NFW and stars.