Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

standardize dev env #360

Closed
wants to merge 20 commits into from
Closed

standardize dev env #360

wants to merge 20 commits into from

Conversation

chadwhitacre
Copy link
Contributor

Follow-on from #358.

MatthewVita and others added 19 commits November 27, 2015 14:22
@MatthewVita
attempting Heroku deployment
aa063ec
@chadwhitacre
Use puma in production
695bed2
@MatthewVita
apparently heroku node buildpack needs a package.json
ba320df
@MatthewVita
patch to known gulp-sass dep issue
86035a2
@MatthewVita
trying out the postinstall strategy instead of rake (temporary code)
6e48bcc
@chadwhitacre
Simplify postinstall gulp invocation
893132a
@chadwhitacre
Include gulp in production deps
2800424 
Since we want to use gulp in production at Heroku.
@chadwhitacre
Move gulp deps up to top-level package.json
c0700ec
@chadwhitacre
Update gulp-sass from 1.3.3 to 2.1.0
f3d2480
@chadwhitacre
Fold client/package.json down in package.json
25b168a
@chadwhitacre
Flatten client/app/* and gulpfile.js up a level
7334ee2
@chadwhitacre
Simplify database configuration in production
682182c
@chadwhitacre
Document Heroku deployment in the README
2e19e1c
@chadwhitacre
Preen the production db setup paragraph
d0c9eda
@chadwhitacre
Note use of rake -T in db paragraph
f661f40
@chadwhitacre
localhost is the default for database connections
4f1d52f
@chadwhitacre
Use a more generic test for working-ness
b4aebbe
@chadwhitacre
Tweak directions for running locally
ad27b1a 
Only assume `bundle` on `PATH` (not `gulp` or `rails`), and adapt to
`gulpfile.js` now being in the project root.
@chadwhitacre
Fold dev/README.md down into README.md
59d9526
@chadwhitacre chadwhitacre mentioned this pull request Nov 30, 2015
Merged
@chadwhitacre
Move dev/src to bootstrap
c98b362 
We don't need two levels of directory nesting for this, and "bootstrap"
is more descriptive of the purpose here.
@chadwhitacre
Copy link
Contributor Author

Basically I think we should use Heroku buildpacks to build locally, to keep dev and production as similar as possible.

@chadwhitacre
Copy link
Contributor Author

Gosh, we should really have tests. :-(

@chadwhitacre
Copy link
Contributor Author

https://docs.travis-ci.com/user/customizing-the-build/

@chadwhitacre
Copy link
Contributor Author

I'm abandoning this until after we have CI.

@chadwhitacre chadwhitacre deleted the standardize-dev-env branch December 1, 2015 00:49
@chadwhitacre chadwhitacre mentioned this pull request Dec 1, 2015
Closed
@MatthewVita
Copy link
Contributor

@whit537:

Gosh, we should really have tests. :-(

I agree, but we opted to wait until stage 3 of the roadmap (http://cityasacampus.org/doc/roadmap.html), which is post-MVP to write the unit tests. Not very conventional, but unit tests, logging, and great documentation are all called out under the "tech debt" label that I'll make an epic for post-MVP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chadwhitacre @MatthewVita