attempting Heroku deployment

[MatthewVita]

@whit537 starting out here.

Going to set up a fresh heroku box and try these rake tasks. I'm not sure if doing the steps through rake tasks is the most elegant approach, tbh.

[MatthewVita]

$ heroku login
$ heroku create
$ heroku config:set RAILS_SERVE_STATIC_FILES=enabled
$ heroku config:set RAILS_ENV=production
$ heroku config:set RAILS_ENV=production
$ heroku config:set APP_TOKEN=foo123abc
$ heroku config:set APP_SECRET=bar789xyz
$ heroku config:set APP_DATABASE_USER=somebody
$ heroku config:set APP_DATABASE_PASS=somepass
$ git push heroku heroku-matthew:master
$ heroku run rake db:migrate
$ heroku run rake db:seed
$ heroku run rake npm
$ heroku run rake gulp

...note that everything is good until the rake npm and gulp commands :( I don't know where the app directory is on heroku

[MatthewVita]

wait...

matthew@matthew-VirtualBox ~/code/cityasacampus $ heroku run bash
Running bash on arcane-island-8296... up, run.2489
~ $ ls
app   config     dev           GETTING_STARTED.md  Rakefile   vendor
app.json  config.ru  examples      lib         README.md
bin   datamodel.pdf  Gemfile       log         test
client    db         Gemfile.lock  public          tmp
~ $ pwd
/app
~ $ 

w00t! need to amend this branch

[MatthewVita]

btw, we're https://arcane-island-8296.herokuapp.com/dashboard/users/sign_in

[MatthewVita]

https://arcane-island-8296.herokuapp.com/ has no static assets to serve up atm, of course

[chadwhitacre]

@MatthewVita The db:migrate and db:seed tasks are one-time, right? How about npm and gulp? Do those need to be run once, or every time we deploy?

[chadwhitacre]

Heroku is designed for dynamic resources, not static ones. We should consider using a CDN for our static assets. Here's Heroku's docs on integrating with Amazon CloudFront. Over on Gratipay, we're using MaxCDN successfully for static assets.

[chadwhitacre]

What's our current static setup? How do npm/gulp interact with the Rails asset pipeline, if at all?

[MatthewVita]

@whit537 I should be clear: gulp just "compiles" our frontend to the Rails "public" directory

[MatthewVita]

db:migrate, npm, and gulp should be run every push, yes

[chadwhitacre]

Okay, and the npm install is so we can use gulp, right?

[MatthewVita]

yes, and so we can have frontend dependencies resolved (such as angular, jquery, etc)

[chadwhitacre]

Resolved when/where? Per-request on the server side or something?

[MatthewVita]

npm downloads the dependencies and gulp shoves them into the vendors.min.js and vendors.min.css files

[chadwhitacre]

Looks like you're on the right track with heroku run rake db:migrate:

https://devcenter.heroku.com/articles/getting-started-with-rails4#migrate-your-database

[chadwhitacre]

npm downloads the dependencies and gulp shoves them into the vendors.min.js and vendors.min.css files

Okay, so still only happening once per deploy.

[chadwhitacre]

Regardless of the webserver you choose, production apps should always specify the webserver explicitly in the Procfile.

https://devcenter.heroku.com/articles/getting-started-with-rails4#webserver

[MatthewVita]

cool. Do you mind looking into that? I'm currently fighting with getting rake task to run correctly (almost there...)

[MatthewVita]

btw, WebBrick is currently what's being used, which is not good

[chadwhitacre]

Some pointers for static files:

• https://devcenter.heroku.com/articles/rails-asset-pipeline
• https://devcenter.heroku.com/articles/rails-4-asset-pipeline
• https://github.com/heroku/rails_12factor#rails-4-serve-static-assets
• RAILS_SERVE_STATIC_FILES

[MatthewVita]

damnit. Heroku has node installed by default but not npm...

[chadwhitacre]

Do you mind looking into that?

Sure thing! :-)

[MatthewVita]

heroku buildpacks:set https://github.com/heroku/heroku-buildpack-nodejs#v83

hmmmm

[MatthewVita]

remote:  !     Push rejected, failed to detect set buildpack https://github.com/heroku/heroku-buildpack-nodejs#v83
remote: More info: https://devcenter.heroku.com/articles/buildpacks#detection-failure

https://github.com/heroku/heroku-buildpack-nodejs#v83
Unsetting https://github.com/heroku/heroku-buildpack-nodejs#v83 and restarting arcane-island-8296... done

nope :(

[chadwhitacre]

I've achieved parity with #358 (comment):

http://still-tor-9977.herokuapp.com/dashboard/users/sign_in

[chadwhitacre]

/me reads https://devcenter.heroku.com/articles/deploying-rails-applications-with-the-puma-web-server

[MatthewVita]

/me trying to figure out how to install npm with buildpacks and failing miserably lol

[chadwhitacre]

@MatthewVita Not sure how you're approaching it, but you should only have one buildpack per application. Either we use Heroku's official Rails buildpack, or their official Node.js one, or we roll our own that combines the two. Seems like we should be able to find a way to install npm without rolling our own buildpack.

[chadwhitacre]

@dmtroyer Reticketed as #359! :-)

[chadwhitacre]

Alright @dmtroyer @MatthewVita, ready for review! :-)

[chadwhitacre]

I'm reviewing local dev deployment ...

[chadwhitacre]

I think there are some other changes we should make to local dev deployment, but they're out of scope for this PR. Reticketed as #360.

[chadwhitacre]

This PR breaks the scripts in dev. I'm going to fix those here to remove a reason not to merge this :-), though I think we should change them (#360).

[chadwhitacre]

Hmm ... I ran dev/src/install.sh against a clean DigitalOcean droplet, and it appears to have completed successfully, though I can't access the app server externally, I believe because it's bound to localhost.

[chadwhitacre]

[I]t appears to have completed successfully, though I can't access the app server externally, I believe because it's bound to localhost.

I think I'm gonna consider that good enough for this PR. S'okay, @MatthewVita?

[MatthewVita]

@whit537 thanks for your patience and great work.

Hmm ... I ran dev/src/install.sh against a clean DigitalOcean droplet, and it appears to have completed successfully, though I can't access the app server externally, I believe because it's bound to localhost.

Just tried it on a fresh EC2 instance and the following worked:

ubuntu@ip-172-31-34-97:~/cityasacampus/dev/src$ rails s & sleep 3 && wget localhost:3000 && cat index.html #spits out HTML

ubuntu@ip-172-31-34-97:~/cityasacampus/dev/src$ rails s & sleep 3 && wget localhost:3000/topics.json && cat topics.json #spits out JSON from GET endpoint

I'm going to merge now. My only comment was on how you did the comments in package.json... according to http://stackoverflow.com/a/14221781 we should be able to use the key "//" to comment in package.json, but it didn't work :(.

I also ripped out the old rake tasks here: hhttps://github.com/saxifrage/cityasacampus/commit/485a2996588d5329a4acb770b9dab0eaae6d6b37

[chadwhitacre]

My only comment was on how you did the comments in package.json... according to http://stackoverflow.com/a/14221781 we should be able to use the key "//" to comment in package.json, but it didn't work :(.

Right. See http://stackoverflow.com/questions/14221579/how-do-i-add-comments-to-package-json-for-npm-install/14221781#comment50530934_14221781.

I also ripped out the old rake tasks

wfm

I'm going to merge now.

Woo-hoo! Thank you! :-D