Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onboard facebook custom audience to transformer proxy #2769

Merged
merged 15 commits into from
Oct 30, 2023

Conversation

shrouti1507
Copy link
Contributor

Description of the change

Onboarding facebook custom audience with transformer proxy
resolve INT-485

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@shrouti1507 shrouti1507 self-assigned this Oct 26, 2023
@shrouti1507 shrouti1507 requested review from a team as code owners October 26, 2023 10:43
@shrouti1507 shrouti1507 changed the title feat: error codes added in fbUtils feat: onboard facebook custom audience to transformer proxy Oct 26, 2023
koladilip
koladilip previously approved these changes Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9c4fcd3) 87.13% compared to head (989a3f7) 87.14%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2769   +/-   ##
========================================
  Coverage    87.13%   87.14%           
========================================
  Files          763      766    +3     
  Lines        28441    28445    +4     
  Branches      6657     6657           
========================================
+ Hits         24783    24787    +4     
  Misses        3321     3321           
  Partials       337      337           
Files Coverage Δ
.../destinations/fb_custom_audience/networkHandler.js 100.00% <100.00%> (ø)
src/v0/util/facebookUtils/networkHandler.js 100.00% <ø> (ø)
...s/destinations/facebook_pixel/dataDelivery/data.ts 100.00% <ø> (ø)
.../integrations/destinations/fb/dataDelivery/data.ts 100.00% <ø> (ø)
...stinations/fb_custom_audience/dataDelivery/data.ts 100.00% <100.00%> (ø)
...rations/destinations/fb_custom_audience/network.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shrouti1507 shrouti1507 requested review from sivashanmukh and a team as code owners October 27, 2023 06:29
@utsabc
Copy link
Member

utsabc commented Oct 30, 2023

Please add facebook status code documentation in the code for later references

anantjain45823
anantjain45823 previously approved these changes Oct 30, 2023
anantjain45823
anantjain45823 previously approved these changes Oct 30, 2023
utsabc
utsabc previously approved these changes Oct 30, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@shrouti1507 shrouti1507 merged commit 14c5e40 into develop Oct 30, 2023
14 checks passed
@sanpj2292 sanpj2292 deleted the feat.fbAud_proxy branch October 30, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants