-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: onboard facebook custom audience to transformer proxy #2769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrouti1507
changed the title
feat: error codes added in fbUtils
feat: onboard facebook custom audience to transformer proxy
Oct 26, 2023
koladilip
previously approved these changes
Oct 26, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2769 +/- ##
========================================
Coverage 87.13% 87.14%
========================================
Files 763 766 +3
Lines 28441 28445 +4
Branches 6657 6657
========================================
+ Hits 24783 24787 +4
Misses 3321 3321
Partials 337 337
☔ View full report in Codecov by Sentry. |
krishna2020
reviewed
Oct 27, 2023
Please add facebook status code documentation in the code for later references |
anantjain45823
previously approved these changes
Oct 30, 2023
anantjain45823
previously approved these changes
Oct 30, 2023
utsabc
previously approved these changes
Oct 30, 2023
Kudos, SonarCloud Quality Gate passed! |
yashasvibajpai
approved these changes
Oct 30, 2023
sanpj2292
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Type of change
Related issues
Checklists
Development
Code review