Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onboard facebook custom audience to transformer proxy #2769

Merged
merged 15 commits into from
Oct 30, 2023
Merged

feat: onboard facebook custom audience to transformer proxy #2769

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
2db3555
feat: error codes added in fbUtils
shrouti1507 Oct 26, 2023
d2ca35c
adding single test case
shrouti1507 Oct 27, 2023
fb33bec
adding test cases in new format
shrouti1507 Oct 27, 2023
6baa162
adding test cases in new format
shrouti1507 Oct 27, 2023
47c0a9a
fix: fixing the test cases
shrouti1507 Oct 30, 2023
213a2dc
fix: cleaning up files
shrouti1507 Oct 30, 2023
260c8b4
fix: cleaning up files
shrouti1507 Oct 30, 2023
d01a99c
fix: cleaning up files
shrouti1507 Oct 30, 2023
c4ea1f0
Merge branch 'develop' into feat.fbAud_proxy
shrouti1507 Oct 30, 2023
e8a7373
fix: review comments addressed
shrouti1507 Oct 30, 2023
684a630
fix: review comments addressed
shrouti1507 Oct 30, 2023
b345c8b
Empty commit
shrouti1507 Oct 30, 2023
9935bd5
Merge branch 'develop' into feat.fbAud_proxy
ujjwal-ab Oct 30, 2023
b2890b8
fix: deleting wrongly spelled file
Oct 30, 2023
989a3f7
fix: add network handler for fb_custom_audience with correct spelling
Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/v0/destinations/fb_custom_audience/networkhandler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
const { networkHandler, errorResponseHandler } = require('../../util/facebookUtils/networkHandler');

module.exports = {
networkHandler,
errorResponseHandler,
};
43 changes: 42 additions & 1 deletion src/v0/util/facebookUtils/networkHandler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ const errorDetailsMap = {
33: new ErrorDetailsExtractorBuilder()
.setStatus(400)
.setMessage(
"Object with ID 'PIXEL_ID' does not exist, cannot be loaded due to missing permissions, or does not support this operation",
"Object with ID 'PIXEL_ID' / 'DATASET_ID' / 'AUDIENCE_ID' does not exist, cannot be loaded due to missing permissions, or does not support this operation",
)
.build(),
default: new ErrorDetailsExtractorBuilder()
Expand Down Expand Up @@ -151,6 +151,47 @@ const errorDetailsMap = {
.setMessage('API User Too Many Calls')
.build(),
},
shrouti1507 marked this conversation as resolved.
Show resolved Hide resolved
// facebook custom audience related error codes
294: {
default: new ErrorDetailsExtractorBuilder()
.setStatus(400)
.setMessage(
'Missing permission. Please make sure you have ads_management permission and the application is included in the allowlist',
)
.build(),
},
1487301: {
default: new ErrorDetailsExtractorBuilder()
.setStatus(400)
.setMessage(
'Custom Audience Unavailable: The custom audience you are trying to use has not been shared with your ad account',
)
.build(),
},
1487366: {
default: new ErrorDetailsExtractorBuilder()
.setStatus(400)
.setMessage('Custom Audience Has Been Deleted')
.build(),
},
2650: {
default: new ErrorDetailsExtractorBuilder()
.setStatus(400)
.setMessage('Failed to update the custom audience')
.build(),
},
105: {
default: new ErrorDetailsExtractorBuilder()
.setStatus(400)
.setMessage('The number of parameters exceeded the maximum for this operation')
.build(),
},
80003: {
default: new ErrorDetailsExtractorBuilder()
.setStatus(429)
.setMessage('There have been too many calls to this ad-account.')
.build(),
},
};

const getErrorDetailsFromErrorMap = (error) => {
Expand Down
2 changes: 1 addition & 1 deletion test/__tests__/data/facebook_pixel_proxy_output.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
{
"output": {
"status": 400,
"message": "Object with ID 'PIXEL_ID' does not exist, cannot be loaded due to missing permissions, or does not support this operation",
"message": "Object with ID 'PIXEL_ID' / 'DATASET_ID' / 'AUDIENCE_ID' does not exist, cannot be loaded due to missing permissions, or does not support this operation",
"destinationResponse": {
"error": {
"message": "Unsupported post request. Object with ID '1234567891234569' does not exist, cannot be loaded due to missing permissions, or does not support this operation. Please read the Graph API documentation at https://developers.facebook.com/docs/graph-api",
Expand Down
2 changes: 1 addition & 1 deletion test/__tests__/data/fb_proxy_output.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
{
"output": {
"status": 400,
"message": "Object with ID 'PIXEL_ID' does not exist, cannot be loaded due to missing permissions, or does not support this operation",
"message": "Object with ID 'PIXEL_ID' / 'DATASET_ID' / 'AUDIENCE_ID' does not exist, cannot be loaded due to missing permissions, or does not support this operation",
"destinationResponse": {
"error": {
"message": "Unsupported post request. Object with ID '1234567891234569' does not exist, cannot be loaded due to missing permissions, or does not support this operation. Please read the Graph API documentation at https://developers.facebook.com/docs/graph-api",
Expand Down
Loading
Loading