fix: review comments addressed

rudderlabs · Oct 30, 2023 · e8a7373 · e8a7373
1 parent c4ea1f0
commit e8a7373
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/src/v0/util/facebookUtils/networkHandler.js b/src/v0/util/facebookUtils/networkHandler.js
@@ -152,6 +152,9 @@ const errorDetailsMap = {
       .build(),
   },
   // facebook custom audience related error codes
+  // ref:
+  // https://developers.facebook.com/docs/marketing-api/reference/custom-audience/#error-codes-4
+  // https://developers.facebook.com/docs/marketing-api/error-reference/
   294: {
     default: new ErrorDetailsExtractorBuilder()
       .setStatus(400)

diff --git a/test/integrations/destinations/facebook_pixel/dataDelivery/data.ts b/test/integrations/destinations/facebook_pixel/dataDelivery/data.ts
@@ -290,7 +290,7 @@ export const data = [
           output: {
             status: 400,
             message:
-              "Object with ID 'PIXEL_ID' does not exist, cannot be loaded due to missing permissions, or does not support this operation",
+              "Object with ID 'PIXEL_ID' / 'DATASET_ID' / 'AUDIENCE_ID' does not exist, cannot be loaded due to missing permissions, or does not support this operation",
             destinationResponse: {
               error: {
                 message:

diff --git a/test/integrations/destinations/fb/dataDelivery/data.ts b/test/integrations/destinations/fb/dataDelivery/data.ts
@@ -328,7 +328,7 @@ export const data = [
         "body": {
           "output": {
             "status": 400,
-            "message": "Object with ID 'PIXEL_ID' does not exist, cannot be loaded due to missing permissions, or does not support this operation",
+            "message": "Object with ID 'PIXEL_ID' / 'DATASET_ID' / 'AUDIENCE_ID' does not exist, cannot be loaded due to missing permissions, or does not support this operation",
             "destinationResponse": {
               "error": {
                 "message": "Unsupported post request. Object with ID '1234567891234569' does not exist, cannot be loaded due to missing permissions, or does not support this operation. Please read the Graph API documentation at https://developers.facebook.com/docs/graph-api",