-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add language code definitions and test #141
Conversation
6cc8b7d
to
30c54c4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 12 +1
Lines 685 724 +39
Branches 169 179 +10
=========================================
+ Hits 685 724 +39 ☔ View full report in Codecov by Sentry. |
393f4e9
to
1921942
Compare
Hello @07pepa That's a great start for the PR, but we should now add Pydantic |
b2043b1
to
fb8ebf8
Compare
I am not sure how/why to add this to literal (since it is supported by pydantic) I am not sure what you want me to do. please tell me how to do it or just modify the code.. i am fine with that. Only thing i would add now is a check if all codes are supported with help of some online source of truth (but that would complicate the test code considerably. and we would have to decide on source of truth |
3336049
to
8cf42e1
Compare
Hello @07pepa, Thank you for your contribution! This PR is indeed valuable, particularly in terms of structuring the data. However, I'd like to propose an enhancement, we can use As we're already utilizing Here are some initial resources to help kickstart this integration: Once we establish a similar structure as the one we have for countries in |
good point i will look in detail on monday |
709f459
to
0700867
Compare
5a0a268
to
ca6ac2a
Compare
* added dynamically generated literals based on pycountry * tested all possibilities and errors exhaustively
ca6ac2a
to
e30ac0a
Compare
@yezz123 i am finished .... and test are passing (test are exhaustive) can you add your input on this code or just merge it .... i will probably add curecies next |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ⭐ Thank you @07pepa 🙏🏻
I've added documentation to each function and class, and I will open a PR to add it to the documentation as soon as we release a new version.
I added language definitions