Added LanguageAlpha2 and LanguageName types #153
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I was a bit disappointed that #141 did not implement alpha-2 languages codes, so here's my take at the implementation. Unlike #141, I tried to follow as closely as possible the existing implementation in
country.py
.I thought that naming the types following convention in
country.py
was also much clearer than the obscure segmentation of the ISO 639 standards. Hence, I created two new types:LanguageAlpha2
andLanguageName
and I would suggest refactoringISO639_3
andISO639_5
intoLanguageAlpha3
.